From: Frank Wunderlich <frank-w@public-files.de>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Dan Johansen <strit@manjaro.org>,
Frank Wunderlich <linux@fw-web.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Aw: Re: Re: Re: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb
Date: Sat, 9 Apr 2022 13:13:49 +0200 [thread overview]
Message-ID: <trinity-70f1133c-e884-46a1-979c-e795e0565db4-1649502829040@3c-app-gmx-bap35> (raw)
In-Reply-To: <4559790.iIbC2pHGDl@phil>
> Gesendet: Samstag, 09. April 2022 um 13:01 Uhr
> Von: "Heiko Stuebner" <heiko@sntech.de>
> As far as I understand the issue now after checking the code, this
> patch actually fixes the usb3 series from Peter, right?
right, due to the change the patches from 5.17 were no more directly compatible with 5.18.
for my board without having standalone usb2-ports it breaks both as usb2 is passed
through xhci controller.
> I.e. the usb-nodes that are fixed in this patch are not yet present
> in the main rk356x dtsi and only get added in
> "arm64: dts: rockchip: add rk356x dwc3 usb3 nodes" [0]
>
> As we don't want to add broken changes, this fix should squashed
> into a next version of the patch adding the nodes.
right, that was my intention, but do not forget the suspend_clk change i've mentioned in [1]
but to leave all know that this bug is known and how to solve it i've posted official patch but
without fixes-tag as the "breaking" commit does not really break...more likely introduce a
incompatibility for the not yet applied patchset.
> [0] https://lore.kernel.org/r/20220408151237.3165046-4-pgwipeout@gmail.com
[1] https://patchwork.kernel.org/comment/24809714/
regards Frank
next prev parent reply other threads:[~2022-04-09 11:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 7:51 [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb Frank Wunderlich
2022-04-09 10:14 ` Aw: " Frank Wunderlich
2022-04-09 10:23 ` Heiko Stuebner
2022-04-09 10:32 ` Aw: " Frank Wunderlich
2022-04-09 10:40 ` Dan Johansen
2022-04-09 10:57 ` Aw: " Frank Wunderlich
2022-04-09 11:01 ` Heiko Stuebner
2022-04-09 11:13 ` Frank Wunderlich [this message]
2022-04-09 11:14 ` Peter Geis
2022-04-09 11:30 ` Peter Geis
2022-04-09 11:35 ` Heiko Stuebner
2022-04-09 11:51 ` Peter Geis
2022-04-09 11:56 ` Aw: " Frank Wunderlich
2022-04-09 15:26 ` Peter Geis
2022-04-10 16:53 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-70f1133c-e884-46a1-979c-e795e0565db4-1649502829040@3c-app-gmx-bap35 \
--to=frank-w@public-files.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=strit@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).