Re: Linux 2.4.17-pre1

Re: Linux 2.4.17-pre1

[Mikael Pettersson]

On Wed, 28 Nov 2001 13:47:07 -0200 (BRST), Marcelo Tosatti wrote:
>pre1:
>
>- Added missing MODULE_LICENSE("GPL") in some   (Andreas Krennmair)
>  modules

Below is yet another one, for ide-tape.c; please apply.

The files in fs/nls/ that have license tags (nls_iso8859-1.c lacks one),
use "BSD without advertising clause", which causes the kernel to be
tainted. Shouldn't fs/nls/*.c use "Dual BSD/GPL" or "GPL" instead?

/Mikael

--- linux-2.4.17-pre1/drivers/ide/ide-tape.c.~1~	Thu Aug 16 23:47:01 2001
+++ linux-2.4.17-pre1/drivers/ide/ide-tape.c	Wed Nov 28 20:34:07 2001
@@ -6182,6 +6182,7 @@
 };
 
 MODULE_DESCRIPTION("ATAPI Streaming TAPE Driver");
+MODULE_LICENSE("GPL");
 
 static void __exit idetape_exit (void)
 {

Re: Linux 2.4.17-pre1

[Alan Cox]

> use "BSD without advertising clause", which causes the kernel to be
> tainted. Shouldn't fs/nls/*.c use "Dual BSD/GPL" or "GPL" instead?

Dual BSD/GPL is the correct one.  Not a big issue. Since the GPL allows
stuff to be freer than GPL but still GPL its arguably correct too I suspect

Re: Linux 2.4.17-pre1

[Robert Love]

On Wed, 2001-11-28 at 18:39, Alan Cox wrote:
> > use "BSD without advertising clause", which causes the kernel to be
> > tainted. Shouldn't fs/nls/*.c use "Dual BSD/GPL" or "GPL" instead?
> 
> Dual BSD/GPL is the correct one.  Not a big issue. Since the GPL allows
> stuff to be freer than GPL but still GPL its arguably correct too I
> suspect

I was waiting for confirmation about the license status...without
getting into what license is correct and legal, the current
MODULE_LICENSE value taints the kernel.  The attached patch switches to
Dual BSD/GPL.

Marcelo, please apply.

	Robert Love

diff -urN linux-2.4.17-pre1/fs/nls/nls_cp1251.c linux/fs/nls/nls_cp1251.c
--- linux-2.4.17-pre1/fs/nls/nls_cp1251.c	Wed Nov 28 15:15:10 2001
+++ linux/fs/nls/nls_cp1251.c	Wed Nov 28 18:41:14 2001
@@ -315,4 +315,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp1255.c linux/fs/nls/nls_cp1255.c
--- linux-2.4.17-pre1/fs/nls/nls_cp1255.c	Wed Nov 28 15:15:10 2001
+++ linux/fs/nls/nls_cp1255.c	Wed Nov 28 18:41:29 2001
@@ -396,4 +396,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp437.c linux/fs/nls/nls_cp437.c
--- linux-2.4.17-pre1/fs/nls/nls_cp437.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp437.c	Wed Nov 28 18:41:40 2001
@@ -401,4 +401,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp737.c linux/fs/nls/nls_cp737.c
--- linux-2.4.17-pre1/fs/nls/nls_cp737.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp737.c	Wed Nov 28 18:41:50 2001
@@ -364,4 +364,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp775.c linux/fs/nls/nls_cp775.c
--- linux-2.4.17-pre1/fs/nls/nls_cp775.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp775.c	Wed Nov 28 18:42:00 2001
@@ -333,4 +333,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp850.c linux/fs/nls/nls_cp850.c
--- linux-2.4.17-pre1/fs/nls/nls_cp850.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp850.c	Wed Nov 28 18:42:10 2001
@@ -329,4 +329,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp852.c linux/fs/nls/nls_cp852.c
--- linux-2.4.17-pre1/fs/nls/nls_cp852.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp852.c	Wed Nov 28 18:42:22 2001
@@ -351,4 +351,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp855.c linux/fs/nls/nls_cp855.c
--- linux-2.4.17-pre1/fs/nls/nls_cp855.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp855.c	Wed Nov 28 18:42:34 2001
@@ -313,4 +313,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp857.c linux/fs/nls/nls_cp857.c
--- linux-2.4.17-pre1/fs/nls/nls_cp857.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp857.c	Wed Nov 28 18:43:07 2001
@@ -315,4 +315,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp860.c linux/fs/nls/nls_cp860.c
--- linux-2.4.17-pre1/fs/nls/nls_cp860.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp860.c	Wed Nov 28 18:45:14 2001
@@ -378,4 +378,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp861.c linux/fs/nls/nls_cp861.c
--- linux-2.4.17-pre1/fs/nls/nls_cp861.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp861.c	Wed Nov 28 18:43:42 2001
@@ -401,4 +401,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp862.c linux/fs/nls/nls_cp862.c
--- linux-2.4.17-pre1/fs/nls/nls_cp862.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp862.c	Wed Nov 28 18:43:50 2001
@@ -435,4 +435,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp863.c linux/fs/nls/nls_cp863.c
--- linux-2.4.17-pre1/fs/nls/nls_cp863.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp863.c	Wed Nov 28 18:43:59 2001
@@ -395,4 +395,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp864.c linux/fs/nls/nls_cp864.c
--- linux-2.4.17-pre1/fs/nls/nls_cp864.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp864.c	Wed Nov 28 18:44:07 2001
@@ -421,4 +421,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp865.c linux/fs/nls/nls_cp865.c
--- linux-2.4.17-pre1/fs/nls/nls_cp865.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp865.c	Wed Nov 28 18:44:16 2001
@@ -401,4 +401,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp866.c linux/fs/nls/nls_cp866.c
--- linux-2.4.17-pre1/fs/nls/nls_cp866.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp866.c	Wed Nov 28 18:44:36 2001
@@ -319,4 +319,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp869.c linux/fs/nls/nls_cp869.c
--- linux-2.4.17-pre1/fs/nls/nls_cp869.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp869.c	Wed Nov 28 18:44:43 2001
@@ -329,4 +329,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");
diff -urN linux-2.4.17-pre1/fs/nls/nls_cp874.c linux/fs/nls/nls_cp874.c
--- linux-2.4.17-pre1/fs/nls/nls_cp874.c	Wed Nov 28 15:15:09 2001
+++ linux/fs/nls/nls_cp874.c	Wed Nov 28 18:44:51 2001
@@ -287,4 +287,4 @@
  * c-continued-brace-offset: 0
  * End:
  */
-MODULE_LICENSE("BSD without advertising clause");
+MODULE_LICENSE("Dual BSD/GPL");

Re: Linux 2.4.17-pre1

[Mark Hymers]

On Wed, 28, Nov, 2001 at 06:48:13PM -0500, Robert Love spoke thus..
> On Wed, 2001-11-28 at 18:39, Alan Cox wrote:
> > > use "BSD without advertising clause", which causes the kernel to
> > > be
> > > tainted. Shouldn't fs/nls/*.c use "Dual BSD/GPL" or "GPL" instead?
> >
> > Dual BSD/GPL is the correct one.  Not a big issue. Since the GPL
> > allows
> > stuff to be freer than GPL but still GPL its arguably correct too I
> > suspect
>
> I was waiting for confirmation about the license status...without
> getting into what license is correct and legal, the current
> MODULE_LICENSE value taints the kernel.  The attached patch switches
> to
> Dual BSD/GPL.
Do you know what the legal status of the rest of the *.c files in fs/nls
is?  There are still quite a few which have no MODULE_LICENSE tag at all
which causes the kernel to be tainted (IMO) incorrectly.

Mark

-- 
Mark Hymers					 BLFS Editor
markh@linuxfromscratch.org

Re: Linux 2.4.17-pre1

[Robert Love]

On Wed, 2001-11-28 at 19:05, Mark Hymers wrote:

> Do you know what the legal status of the rest of the *.c files in fs/nls
> is?  There are still quite a few which have no MODULE_LICENSE tag at all
> which causes the kernel to be tainted (IMO) incorrectly.

I believe all the fs/nls files are GPL or Dual GPL/something else.

	Robert Love

Re: Linux 2.4.17-pre1

[Marcelo Tosatti]

On Wed, 28 Nov 2001, Mike Fedyk wrote:

> On Wed, Nov 28, 2001 at 01:47:07PM -0200, Marcelo Tosatti wrote:
> > 
> > 
> > Ok, 2.4.17-pre1 is out. Still going to the mirrors though, so please wait
> > a while if you haven't found a copy on your local mirror. 
> > 
> > 
> > pre1:
> > 
> 
> Any chance you'll merge Robert's netdev-random uniformity cleanup patch with
> the default to "no"?

Not sure. Have to read the patch... 

Re: Linux 2.4.17-pre1

[Robert Love]

On Wed, 2001-11-28 at 22:13, Ken Brownfield wrote:>
> Seconded.  Off by default and with appropriate security caveats in the
> Configure.help section, which Robert has already mentioned.
> 
> It's pretty critical given the burgeoning amount of cryptography in
> production environments where entropy from disk I/O is essentially
> non-existent.  The security concerns are very valid, but many trade-offs
> are worth it, IMHO.  I will most likely be dead in the water soon unless
> I start using this patch in certain places.

For those interested, the patch is at
	ftp://ftp.kernel.org/pub/linux/kernel/people/rml/netdev-random

I want to point out that _without_ this patch, there are network devices
that feed the entropy pool.  In other words, this patch standardizes the
situation.

If you don't want net devices contributing, accept the default.

If you do, enable the configure setting and they all will contribute to
/dev/random.  This has uses in diskless/headless configurations, etc.

> On Wed, Nov 28, 2001 at 06:56:01PM -0800, Mike Fedyk wrote:
> | Any chance you'll merge Robert's netdev-random uniformity cleanup
> | patch with the default to "no"?

	Robert Love

Re: Linux 2.4.17-pre1

[Ken Brownfield]

Seconded.  Off by default and with appropriate security caveats in the
Configure.help section, which Robert has already mentioned.

It's pretty critical given the burgeoning amount of cryptography in
production environments where entropy from disk I/O is essentially
non-existent.  The security concerns are very valid, but many trade-offs
are worth it, IMHO.  I will most likely be dead in the water soon unless
I start using this patch in certain places.

Just my two humble cents,
-- 
Ken.
brownfld@irridia.com

On Wed, Nov 28, 2001 at 06:56:01PM -0800, Mike Fedyk wrote:
| On Wed, Nov 28, 2001 at 01:47:07PM -0200, Marcelo Tosatti wrote:
| > 
| > 
| > Ok, 2.4.17-pre1 is out. Still going to the mirrors though, so please wait
| > a while if you haven't found a copy on your local mirror. 
| > 
| > 
| > pre1:
| > 
| 
| Any chance you'll merge Robert's netdev-random uniformity cleanup patch with
| the default to "no"?
| 
| mf
| -
| To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
| the body of a message to majordomo@vger.kernel.org
| More majordomo info at  http://vger.kernel.org/majordomo-info.html
| Please read the FAQ at  http://www.tux.org/lkml/

Re: Linux 2.4.17-pre1

[Mike Fedyk]

On Wed, Nov 28, 2001 at 01:47:07PM -0200, Marcelo Tosatti wrote:
> 
> 
> Ok, 2.4.17-pre1 is out. Still going to the mirrors though, so please wait
> a while if you haven't found a copy on your local mirror. 
> 
> 
> pre1:
> 

Any chance you'll merge Robert's netdev-random uniformity cleanup patch with
the default to "no"?

mf

Re: Linux 2.4.17-pre1

[Tommy Reynolds]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Quick to seize an opportunity, "Marcelo Tosatti" <marcelo@conectiva.com.br> wrote:

> Yes, I forgot to do that in this release, sorry.
> 
> Hope it never happens again. 

It's OK to make mistakes, as long as they're new ones ;-)

---------------------------------------------+-----------------------------
Tommy Reynolds                               | mailto: <reynolds@redhat.com>
Red Hat, Inc., Embedded Development Services | Phone:  +1.256.704.9286
307 Wynn Drive NW, Huntsville, AL 35805 USA  | FAX:    +1.256.837.3839
Senior Software Developer                    | Mobile: +1.919.641.2923

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Linux 2.4.17-pre1

[Andrey Nekrasov]

Hello Marcelo Tosatti,


Please, don`t forget change PATCHLEVEL/SUBLEVEL/EXTRAVERSION.

 
> Ok, 2.4.17-pre1 is out. Still going to the mirrors though, so please wait
> a while if you haven't found a copy on your local mirror. 
> 
> 
> pre1:
> 
> - Change USB maintainer 			(Greg Kroah-Hartman)
> - Speeling fix for rd.c				(From Ralf Baechle's tree)
> - Updated URL for bigphysmem patch in v4l docs  (Adrian Bunk)
> - Add buggy 440GX to broken pirq blacklist 	(Arjan Van de Ven)
> - Add new entry to Sound blaster ISAPNP list	(Arjan Van de Ven)
> - Remove crap character from Configure.help	(Niels Kristian Bech Jensen)
> - Backout erroneous change to lookup_exec_domain (Christoph Hellwig)
> - Update osst sound driver to 1.65		(Willem Riede)
> - Fix i810 sound driver problems		(Andris Pavenis)
> - Add AF_LLC define in network headers		(Arnaldo Carvalho de Melo)
> - block_size cleanup on some SCSI drivers	(Erik Andersen)
> - Added missing MODULE_LICENSE("GPL") in some   (Andreas Krennmair)
>   modules
> - Add ->show_options() to super_ops and 
>   implement NFS method				(Alexander Viro)
> - Updated i8k driver				(Massimo Dal Zoto)
> - devfs update  				(Richard Gooch)
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
bye.
Andrey Nekrasov, SpyLOG.

Re: Linux 2.4.17-pre1

[Marcelo Tosatti]

Yes, I forgot to do that in this release, sorry.

Hope it never happens again. 

On Wed, 28 Nov 2001, Andrey Nekrasov wrote:

> Hello Marcelo Tosatti,
> 
> 
> Please, don`t forget change PATCHLEVEL/SUBLEVEL/EXTRAVERSION.
> 
>  
> > Ok, 2.4.17-pre1 is out. Still going to the mirrors though, so please wait
> > a while if you haven't found a copy on your local mirror. 
> > 
> > 
> > pre1:
> > 
> > - Change USB maintainer 			(Greg Kroah-Hartman)
> > - Speeling fix for rd.c				(From Ralf Baechle's tree)
> > - Updated URL for bigphysmem patch in v4l docs  (Adrian Bunk)
> > - Add buggy 440GX to broken pirq blacklist 	(Arjan Van de Ven)
> > - Add new entry to Sound blaster ISAPNP list	(Arjan Van de Ven)
> > - Remove crap character from Configure.help	(Niels Kristian Bech Jensen)
> > - Backout erroneous change to lookup_exec_domain (Christoph Hellwig)
> > - Update osst sound driver to 1.65		(Willem Riede)
> > - Fix i810 sound driver problems		(Andris Pavenis)
> > - Add AF_LLC define in network headers		(Arnaldo Carvalho de Melo)
> > - block_size cleanup on some SCSI drivers	(Erik Andersen)
> > - Added missing MODULE_LICENSE("GPL") in some   (Andreas Krennmair)
> >   modules
> > - Add ->show_options() to super_ops and 
> >   implement NFS method				(Alexander Viro)
> > - Updated i8k driver				(Massimo Dal Zoto)
> > - devfs update  				(Richard Gooch)
> > 
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> bye.
> Andrey Nekrasov, SpyLOG.
> 

Linux 2.4.17-pre1

[Marcelo Tosatti]

Ok, 2.4.17-pre1 is out. Still going to the mirrors though, so please wait
a while if you haven't found a copy on your local mirror. 


pre1:

- Change USB maintainer 			(Greg Kroah-Hartman)
- Speeling fix for rd.c				(From Ralf Baechle's tree)
- Updated URL for bigphysmem patch in v4l docs  (Adrian Bunk)
- Add buggy 440GX to broken pirq blacklist 	(Arjan Van de Ven)
- Add new entry to Sound blaster ISAPNP list	(Arjan Van de Ven)
- Remove crap character from Configure.help	(Niels Kristian Bech Jensen)
- Backout erroneous change to lookup_exec_domain (Christoph Hellwig)
- Update osst sound driver to 1.65		(Willem Riede)
- Fix i810 sound driver problems		(Andris Pavenis)
- Add AF_LLC define in network headers		(Arnaldo Carvalho de Melo)
- block_size cleanup on some SCSI drivers	(Erik Andersen)
- Added missing MODULE_LICENSE("GPL") in some   (Andreas Krennmair)
  modules
- Add ->show_options() to super_ops and 
  implement NFS method				(Alexander Viro)
- Updated i8k driver				(Massimo Dal Zoto)
- devfs update  				(Richard Gooch)