* [PATCH] rcu: include torture_sched_setaffinity() declaration
@ 2023-08-03 14:40 Arnd Bergmann
2023-08-03 16:02 ` Joel Fernandes
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-08-03 14:40 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Arnd Bergmann, Frederic Weisbecker, Neeraj Upadhyay,
Joel Fernandes, Josh Triplett, Boqun Feng, Steven Rostedt,
Mathieu Desnoyers, Lai Jiangshan, Zqiang, Zhen Lei, rcu,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The prototype for torture_sched_setaffinity() moved to a
different header, which needs to be included from update.c
to avoid this W=1 warning:
kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/rcu/update.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
index 0533b510f0a8..c534d6806d3d 100644
--- a/kernel/rcu/update.c
+++ b/kernel/rcu/update.c
@@ -25,6 +25,7 @@
#include <linux/interrupt.h>
#include <linux/sched/signal.h>
#include <linux/sched/debug.h>
+#include <linux/torture.h>
#include <linux/atomic.h>
#include <linux/bitops.h>
#include <linux/percpu.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rcu: include torture_sched_setaffinity() declaration
2023-08-03 14:40 [PATCH] rcu: include torture_sched_setaffinity() declaration Arnd Bergmann
@ 2023-08-03 16:02 ` Joel Fernandes
2023-08-03 16:32 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Joel Fernandes @ 2023-08-03 16:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Paul E. McKenney, Arnd Bergmann, Frederic Weisbecker,
Neeraj Upadhyay, Josh Triplett, Boqun Feng, Steven Rostedt,
Mathieu Desnoyers, Lai Jiangshan, Zqiang, Zhen Lei, rcu,
linux-kernel
On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The prototype for torture_sched_setaffinity() moved to a
> different header, which needs to be included from update.c
> to avoid this W=1 warning:
>
> kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
> 529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
>
> Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
thanks,
- Joel
> ---
> kernel/rcu/update.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> index 0533b510f0a8..c534d6806d3d 100644
> --- a/kernel/rcu/update.c
> +++ b/kernel/rcu/update.c
> @@ -25,6 +25,7 @@
> #include <linux/interrupt.h>
> #include <linux/sched/signal.h>
> #include <linux/sched/debug.h>
> +#include <linux/torture.h>
> #include <linux/atomic.h>
> #include <linux/bitops.h>
> #include <linux/percpu.h>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rcu: include torture_sched_setaffinity() declaration
2023-08-03 16:02 ` Joel Fernandes
@ 2023-08-03 16:32 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2023-08-03 16:32 UTC (permalink / raw)
To: Joel Fernandes
Cc: Arnd Bergmann, Arnd Bergmann, Frederic Weisbecker,
Neeraj Upadhyay, Josh Triplett, Boqun Feng, Steven Rostedt,
Mathieu Desnoyers, Lai Jiangshan, Zqiang, Zhen Lei, rcu,
linux-kernel
On Thu, Aug 03, 2023 at 12:02:52PM -0400, Joel Fernandes wrote:
> On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The prototype for torture_sched_setaffinity() moved to a
> > different header, which needs to be included from update.c
> > to avoid this W=1 warning:
> >
> > kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
> > 529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
> >
> > Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Queued (likely for the v6.7 merge window), thank you both!
Thanx, Paul
> thanks,
>
> - Joel
>
>
> > ---
> > kernel/rcu/update.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> > index 0533b510f0a8..c534d6806d3d 100644
> > --- a/kernel/rcu/update.c
> > +++ b/kernel/rcu/update.c
> > @@ -25,6 +25,7 @@
> > #include <linux/interrupt.h>
> > #include <linux/sched/signal.h>
> > #include <linux/sched/debug.h>
> > +#include <linux/torture.h>
> > #include <linux/atomic.h>
> > #include <linux/bitops.h>
> > #include <linux/percpu.h>
> > --
> > 2.39.2
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-03 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 14:40 [PATCH] rcu: include torture_sched_setaffinity() declaration Arnd Bergmann
2023-08-03 16:02 ` Joel Fernandes
2023-08-03 16:32 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).