linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: broonie@kernel.org, Jon Lin <jon.lin@rock-chips.com>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@esmil.dk, Jon Lin <jon.lin@rock-chips.com>
Subject: Re: [PATCH v1 2/8] spi: rockchip: add compatible string for rv1126
Date: Fri, 23 Apr 2021 11:00:18 +0200	[thread overview]
Message-ID: <10186800.nitPUkWRp2@diego> (raw)
In-Reply-To: <20210423084155.17439-2-jon.lin@rock-chips.com>

Hi Jon,

Am Freitag, 23. April 2021, 10:41:49 CEST schrieb Jon Lin:
> Add compatible string for rv1126 to applications for potential
> applications.
> 
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
>  drivers/spi/spi-rockchip.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index 52d6259d96ed..dae0281f6ba8 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -911,7 +911,9 @@ static const struct dev_pm_ops rockchip_spi_pm = {
>  };
>  
>  static const struct of_device_id rockchip_spi_dt_match[] = {
> -	{ .compatible = "rockchip,px30-spi", },
> +	{ .compatible = "rockchip,px30-spi",   },

unrelated change with the add "space" at the end

> +	{ .compatible = "rockchip,rv1108-spi", },
> +	{ .compatible = "rockchip,rv1126-spi", },

it seems the list was sorted alphabetically, so rv* comes after rk*
which is probably why the rv1108 was at the bottom and rightfully so.


Heiko

>  	{ .compatible = "rockchip,rk3036-spi", },
>  	{ .compatible = "rockchip,rk3066-spi", },
>  	{ .compatible = "rockchip,rk3188-spi", },
> @@ -921,7 +923,6 @@ static const struct of_device_id rockchip_spi_dt_match[] = {
>  	{ .compatible = "rockchip,rk3328-spi", },
>  	{ .compatible = "rockchip,rk3368-spi", },
>  	{ .compatible = "rockchip,rk3399-spi", },
> -	{ .compatible = "rockchip,rv1108-spi", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, rockchip_spi_dt_match);
> 





  reply	other threads:[~2021-04-23  9:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  8:41 [PATCH v1 1/8] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-04-23  8:41 ` [PATCH v1 2/8] spi: rockchip: add compatible string " Jon Lin
2021-04-23  9:00   ` Heiko Stübner [this message]
2021-04-23  8:41 ` [PATCH v1 3/8] spi: rockchip: Support cs-gpio Jon Lin
2021-04-23  8:41 ` [PATCH v1 4/8] dt-bindings: spi: spi-rockchip: add description for rk3568 Jon Lin
2021-04-23  8:41 ` [PATCH v1 5/8] spi: rockchip: Add compatible string " Jon Lin
2021-04-23  8:47 ` [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-04-23  8:47   ` [PATCH v1 7/8] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
2021-04-23  8:47   ` [PATCH v1 8/8] spi: rockchip: Support SPI_CS_HIGH Jon Lin
2021-04-23 12:18   ` [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10186800.nitPUkWRp2@diego \
    --to=heiko@sntech.de \
    --cc=broonie@kernel.org \
    --cc=jon.lin@rock-chips.com \
    --cc=kernel@esmil.dk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).