From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.2] i386/dmi_scan updates
Date: 05 Oct 2002 22:13:55 +0100 [thread overview]
Message-ID: <1033852435.4441.19.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20021005201723.A1FA062D01@mallaury.noc.nerim.net>
On Sat, 2002-10-05 at 23:19, Jean Delvare wrote:
> This check has been removed in 2.4 though. I think it was needed when we were
> trusting the structure count (see version 1.1 of dmidecode) instead of
> also verifying we weren't running of the table. Now that this check is
> done, I don't see why we would need the heuristic anymore.
True - btw word wrap is broken on your mailer
> Also note that the white spaces check has been removed from 2.4.
The debug data can basically go
> A better way IMHO would be to "secure" the dmi_string function. If we can
ensure it will always return a safe (that is, null terminated) string, we are done. Agreed?
I'd ascii filter it as well but yes. The length one I dont think is a
problem because the table length will gie us a defined worst case
next prev parent reply other threads:[~2002-10-05 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-05 20:19 [PATCH 2.2] i386/dmi_scan updates Jean Delvare
2002-10-05 21:13 ` Alan Cox [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-10-06 20:03 Jean Delvare
2002-10-06 10:12 Jean Delvare
2002-10-06 16:30 ` Alan Cox
2002-10-06 16:31 ` Alan Cox
2002-10-05 19:36 Jean Delvare
2002-10-05 19:52 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033852435.4441.19.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).