From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.2] i386/dmi_scan updates
Date: 06 Oct 2002 17:30:25 +0100 [thread overview]
Message-ID: <1033921825.21257.8.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20021006101026.92C2A62DC0@mallaury.noc.nerim.net>
On Sun, 2002-10-06 at 13:12, Jean Delvare wrote:
> I don't agree with ASCII filtering. I don't want to enlarge everyone's kernel for just some rare cases where the DMI table is broken *and* debug code is enabled. If you want, I can write the code that does it, but I wouldn't enable it by default.
> As far as the length is concerned, the table length doesn't help, because we check the structure length against the remaining table length. The structure length does *not* include the string data, so we could pass the length test and still run of the table in dmi_string. What's more, the string index could be more that the string count for this structure and no check is done for this.
> I think we need a safer dmi_string function that knows about the table length (or, better indeed, the remaining length from this point), and checks for both string index being too large and string index leading outside the table. Then, the other checks (white space and null byte) will be obsolete.
Our console doesn't handle arbitary 8bit encodings. There are japanese
DMI strings out there for example
next prev parent reply other threads:[~2002-10-06 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-06 10:12 [PATCH 2.2] i386/dmi_scan updates Jean Delvare
2002-10-06 16:30 ` Alan Cox [this message]
2002-10-06 16:31 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-10-06 20:03 Jean Delvare
2002-10-05 20:19 Jean Delvare
2002-10-05 21:13 ` Alan Cox
2002-10-05 19:36 Jean Delvare
2002-10-05 19:52 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033921825.21257.8.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).