* [PATCH] compile fix for dmi_scan.c in 2.4.bk-current
@ 2002-10-15 18:40 john stultz
2002-10-15 18:47 ` john stultz
0 siblings, 1 reply; 6+ messages in thread
From: john stultz @ 2002-10-15 18:40 UTC (permalink / raw)
To: marcelo; +Cc: lkml
Marcelo,
Saw you've inc'ed the EXTRAVERSION in bk, so I figured I should send
this fix to you before you mailed out pre11.
I'm not sure if its the "proper" fix, but solves:
arch/i386/kernel/kernel.o: In function `fix_broken_hp_bios_irq9':
arch/i386/kernel/kernel.o(.text.init+0x3601): undefined reference to
`broken_hp_bios_irq9'
arch/i386/kernel/kernel.o(.text.init+0x3614): undefined reference to
`broken_hp_bios_irq9'
thanks
-john
PS: agpgart seems broken as well, but I don't normally build w/ it, so
I'll leave the fix to someone who knows what they're doing.
--- 1.26/arch/i386/kernel/dmi_scan.c Thu Oct 10 16:12:50 2002
+++ edited/arch/i386/kernel/dmi_scan.c Tue Oct 15 00:55:36 2002
@@ -492,7 +492,7 @@
static __init int fix_broken_hp_bios_irq9(struct dmi_blacklist *d)
{
#ifdef CONFIG_PCI
- extern int broken_hp_bios_irq9;
+ int broken_hp_bios_irq9;
if (broken_hp_bios_irq9 == 0)
{
broken_hp_bios_irq9 = 1;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] compile fix for dmi_scan.c in 2.4.bk-current
2002-10-15 18:40 [PATCH] compile fix for dmi_scan.c in 2.4.bk-current john stultz
@ 2002-10-15 18:47 ` john stultz
2002-10-15 19:03 ` Marcelo Tosatti
0 siblings, 1 reply; 6+ messages in thread
From: john stultz @ 2002-10-15 18:47 UTC (permalink / raw)
To: marcelo; +Cc: lkml
On Tue, 2002-10-15 at 11:40, john stultz wrote:
> I'm not sure if its the "proper" fix, but solves:
Actually, I'm sure that's not the right fix.
In fact its pretty horribly broken as well.
Sorry, next time I'll actually look at what I'm doing before mailing.
-john
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] compile fix for dmi_scan.c in 2.4.bk-current
2002-10-15 18:47 ` john stultz
@ 2002-10-15 19:03 ` Marcelo Tosatti
2002-10-21 15:46 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Marcelo Tosatti @ 2002-10-15 19:03 UTC (permalink / raw)
To: john stultz; +Cc: lkml
On 15 Oct 2002, john stultz wrote:
> On Tue, 2002-10-15 at 11:40, john stultz wrote:
> > I'm not sure if its the "proper" fix, but solves:
>
> Actually, I'm sure that's not the right fix.
> In fact its pretty horribly broken as well.
>
> Sorry, next time I'll actually look at what I'm doing before mailing.
I'll remove the dmi update from Alan for 2.4.20-pre.
Thats a 2.4.21-pre thing.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] compile fix for dmi_scan.c in 2.4.bk-current
2002-10-15 19:03 ` Marcelo Tosatti
@ 2002-10-21 15:46 ` Alan Cox
2002-10-21 16:07 ` Marcelo Tosatti
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2002-10-21 15:46 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: john stultz, lkml
On Tue, 2002-10-15 at 20:03, Marcelo Tosatti wrote:
> I'll remove the dmi update from Alan for 2.4.20-pre.
>
> Thats a 2.4.21-pre thing.
Its very much a 2.4.20 thing. Its just that it accidentally acquired the
HP entry as well which we dont want.
Lose the problem function and the HP specific quirk and you'll get the
bits that actually do matter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] compile fix for dmi_scan.c in 2.4.bk-current
2002-10-21 15:46 ` Alan Cox
@ 2002-10-21 16:07 ` Marcelo Tosatti
2002-10-21 18:07 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Marcelo Tosatti @ 2002-10-21 16:07 UTC (permalink / raw)
To: Alan Cox; +Cc: john stultz, lkml
On 21 Oct 2002, Alan Cox wrote:
> On Tue, 2002-10-15 at 20:03, Marcelo Tosatti wrote:
> > I'll remove the dmi update from Alan for 2.4.20-pre.
> >
> > Thats a 2.4.21-pre thing.
>
> Its very much a 2.4.20 thing. Its just that it accidentally acquired the
> HP entry as well which we dont want.
>
> Lose the problem function and the HP specific quirk and you'll get the
> bits that actually do matter
I merged the HP Pavilion quirks on my tree and then backed it all out
later because I thought the changes were not necessary for 2.4.20.
Which issues the DMI update is addressing?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] compile fix for dmi_scan.c in 2.4.bk-current
2002-10-21 16:07 ` Marcelo Tosatti
@ 2002-10-21 18:07 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2002-10-21 18:07 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: john stultz, lkml
On Mon, 2002-10-21 at 17:07, Marcelo Tosatti wrote:
> > Lose the problem function and the HP specific quirk and you'll get the
> > bits that actually do matter
>
> I merged the HP Pavilion quirks on my tree and then backed it all out
> later because I thought the changes were not necessary for 2.4.20.
>
> Which issues the DMI update is addressing?
The stuff I sent you included a pile of correctness fixes for the DMI
code that are in dmidecode and came from the lm-sensors folk
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-10-21 17:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-15 18:40 [PATCH] compile fix for dmi_scan.c in 2.4.bk-current john stultz
2002-10-15 18:47 ` john stultz
2002-10-15 19:03 ` Marcelo Tosatti
2002-10-21 15:46 ` Alan Cox
2002-10-21 16:07 ` Marcelo Tosatti
2002-10-21 18:07 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).