* [PATCH] Fix typo in sl82c105.c driver
@ 2002-11-07 2:55 Paul Mackerras
2002-11-07 9:36 ` Russell King
2002-11-08 17:38 ` Alan Cox
0 siblings, 2 replies; 4+ messages in thread
From: Paul Mackerras @ 2002-11-07 2:55 UTC (permalink / raw)
To: Jens Axboe, torvalds; +Cc: linux-kernel, benh
This patch fixes a minor typo in sl82c105.c which stops it from
compiling.
Jens and/or Linus, please apply.
Paul.
diff -urN linux-2.5/drivers/ide/pci/sl82c105.c pmac-2.5/drivers/ide/pci/sl82c105.c
--- linux-2.5/drivers/ide/pci/sl82c105.c 2002-10-12 14:40:28.000000000 +1000
+++ pmac-2.5/drivers/ide/pci/sl82c105.c 2002-10-30 12:32:48.000000000 +1100
@@ -284,7 +284,7 @@
static int __devinit sl82c105_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
- ide_pci_device_t *d = &slc82c105_chipsets[id->driver_data];
+ ide_pci_device_t *d = &sl82c105_chipsets[id->driver_data];
if (dev->device != d->device)
BUG();
ide_setup_pci_device(dev, d);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in sl82c105.c driver
2002-11-07 2:55 [PATCH] Fix typo in sl82c105.c driver Paul Mackerras
@ 2002-11-07 9:36 ` Russell King
2002-11-08 17:38 ` Alan Cox
1 sibling, 0 replies; 4+ messages in thread
From: Russell King @ 2002-11-07 9:36 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Jens Axboe, torvalds, linux-kernel, benh
On Thu, Nov 07, 2002 at 01:55:11PM +1100, Paul Mackerras wrote:
> This patch fixes a minor typo in sl82c105.c which stops it from
> compiling.
Grr. It needs _fixing_ first. I haven't managed to get around to fixing
this mess that was created when Martin's stuff got ripped out.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in sl82c105.c driver
2002-11-07 2:55 [PATCH] Fix typo in sl82c105.c driver Paul Mackerras
2002-11-07 9:36 ` Russell King
@ 2002-11-08 17:38 ` Alan Cox
2002-11-08 17:41 ` Russell King
1 sibling, 1 reply; 4+ messages in thread
From: Alan Cox @ 2002-11-08 17:38 UTC (permalink / raw)
To: Paul Mackerras
Cc: Jens Axboe, Linus Torvalds, Linux Kernel Mailing List, benh
On Thu, 2002-11-07 at 02:55, Paul Mackerras wrote:
> This patch fixes a minor typo in sl82c105.c which stops it from
> compiling.
>
> Jens and/or Linus, please apply.
>
> Paul.
>
> diff -urN linux-2.5/drivers/ide/pci/sl82c105.c pmac-2.5/drivers/ide/pci/sl82c105.c
> --- linux-2.5/drivers/ide/pci/sl82c105.c 2002-10-12 14:40:28.000000000 +1000
> +++ pmac-2.5/drivers/ide/pci/sl82c105.c 2002-10-30 12:32:48.000000000 +1100
> @@ -284,7 +284,7 @@
>
> static int __devinit sl82c105_init_one(struct pci_dev *dev, const struct pci_device_id *id)
> {
> - ide_pci_device_t *d = &slc82c105_chipsets[id->driver_data];
> + ide_pci_device_t *d = &sl82c105_chipsets[id->driver_data];
> if (dev->device != d->device)
> BUG();
> ide_setup_pci_device(dev, d);
Looks good to me
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in sl82c105.c driver
2002-11-08 17:38 ` Alan Cox
@ 2002-11-08 17:41 ` Russell King
0 siblings, 0 replies; 4+ messages in thread
From: Russell King @ 2002-11-08 17:41 UTC (permalink / raw)
To: Alan Cox
Cc: Paul Mackerras, Jens Axboe, Linus Torvalds,
Linux Kernel Mailing List, benh
On Fri, Nov 08, 2002 at 05:38:29PM +0000, Alan Cox wrote:
> On Thu, 2002-11-07 at 02:55, Paul Mackerras wrote:
> > This patch fixes a minor typo in sl82c105.c which stops it from
> > compiling.
> >
> > Jens and/or Linus, please apply.
> >
> > Paul.
> >
> > diff -urN linux-2.5/drivers/ide/pci/sl82c105.c pmac-2.5/drivers/ide/pci/sl82c105.c
> > --- linux-2.5/drivers/ide/pci/sl82c105.c 2002-10-12 14:40:28.000000000 +1000
> > +++ pmac-2.5/drivers/ide/pci/sl82c105.c 2002-10-30 12:32:48.000000000 +1100
> > @@ -284,7 +284,7 @@
> >
> > static int __devinit sl82c105_init_one(struct pci_dev *dev, const struct pci_device_id *id)
> > {
> > - ide_pci_device_t *d = &slc82c105_chipsets[id->driver_data];
> > + ide_pci_device_t *d = &sl82c105_chipsets[id->driver_data];
> > if (dev->device != d->device)
> > BUG();
> > ide_setup_pci_device(dev, d);
>
> Looks good to me
It may look good. Shame that the DMA state machine gets screwed if you
have an ATAPI device on either channel, and needs code to reset it prior
to issuing a command.
Sorry, I've not been able to push the fixes forward yet. Its on my todo
list though.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-11-08 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-07 2:55 [PATCH] Fix typo in sl82c105.c driver Paul Mackerras
2002-11-07 9:36 ` Russell King
2002-11-08 17:38 ` Alan Cox
2002-11-08 17:41 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).