* [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix
@ 2003-02-11 18:25 ISHIKAWA Mutsumi
2003-02-11 20:06 ` Justin T. Gibbs
2003-02-11 20:52 ` James Bottomley
0 siblings, 2 replies; 5+ messages in thread
From: ISHIKAWA Mutsumi @ 2003-02-11 18:25 UTC (permalink / raw)
To: jejb, gibbs; +Cc: linux-kernel
This patch will fix two problems.
fix build problem related scsi_cmnd changes
http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/scsi/aic7xxx/aic79xx_osm.c@1.16?nav=index.html|src/|src/drivers|src/drivers/scsi|src/drivers/scsi/aic7xxx|hist/drivers/scsi/aic7xxx/aic79xx_osm.c
This change(latest aic79xx driver and scsi_cmnd changes merging)
is dropped `hscb->lun = cmd->device->lun;' (in aic79xx_osm.c line
4272). This change cause lun detect problem. I believe it is still
needed.
--- linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c.orig 2003-02-11 14:58:01.000000000 +0900
+++ linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c 2003-02-11 16:08:00.000000000 +0900
@@ -1560,7 +1560,7 @@
hscb = scb->hscb;
hscb->control = 0;
hscb->scsiid = BUILD_SCSIID(ahd, cmd);
- hscb->lun = cmd->lun;
+ hscb->lun = cmd->device->lun;
hscb->cdb_len = 0;
hscb->task_management = SIU_TASKMGMT_LUN_RESET;
scb->flags |= SCB_DEVICE_RESET|SCB_RECOVERY_SCB|SCB_ACTIVE;
@@ -4269,6 +4269,7 @@
*/
hscb->control = 0;
hscb->scsiid = BUILD_SCSIID(ahd, cmd);
+ hscb->lun = cmd->device->lun;
scb->hscb->task_management = 0;
mask = SCB_GET_TARGET_MASK(ahd, scb);
--
ISHIKAWA Mutsumi
<ishikawa@linux.or.jp>, <ishikawa@debian.org>, <ishikawa@netvillage.co.jp>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix
2003-02-11 18:25 [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix ISHIKAWA Mutsumi
@ 2003-02-11 20:06 ` Justin T. Gibbs
2003-02-11 20:21 ` Christoph Hellwig
2003-02-11 20:52 ` James Bottomley
1 sibling, 1 reply; 5+ messages in thread
From: Justin T. Gibbs @ 2003-02-11 20:06 UTC (permalink / raw)
To: ISHIKAWA Mutsumi, jejb; +Cc: linux-kernel
> This patch will fix two problems.
>
> fix build problem related scsi_cmnd changes
The aic7xxx driver has one place that missed the conversion too.
Since the cmd->lun field is no longer filled in, why hasn't the
field been removed from the cmd structure? That would make it
easy to catch these kinds of bugs.
Thanks for the report. We're close to doing another aic79xx
driver drop and I'll incorporate the change then.
--
Justin
>
> http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/scsi/aic7xxx/aic79xx_osm.c@1.16?nav=index.html|src/|src/drivers|src/drivers/scsi|src/drivers/scsi/aic7xxx|hist/drivers/scsi/aic7xxx/aic79xx_osm.c
>
> This change(latest aic79xx driver and scsi_cmnd changes merging)
> is dropped `hscb->lun = cmd->device->lun;' (in aic79xx_osm.c line
> 4272). This change cause lun detect problem. I believe it is still
> needed.
>
>
> --- linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c.orig 2003-02-11 14:58:01.000000000 +0900
> +++ linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c 2003-02-11 16:08:00.000000000 +0900
> @@ -1560,7 +1560,7 @@
> hscb = scb->hscb;
> hscb->control = 0;
> hscb->scsiid = BUILD_SCSIID(ahd, cmd);
> - hscb->lun = cmd->lun;
> + hscb->lun = cmd->device->lun;
> hscb->cdb_len = 0;
> hscb->task_management = SIU_TASKMGMT_LUN_RESET;
> scb->flags |= SCB_DEVICE_RESET|SCB_RECOVERY_SCB|SCB_ACTIVE;
> @@ -4269,6 +4269,7 @@
> */
> hscb->control = 0;
> hscb->scsiid = BUILD_SCSIID(ahd, cmd);
> + hscb->lun = cmd->device->lun;
> scb->hscb->task_management = 0;
> mask = SCB_GET_TARGET_MASK(ahd, scb);
>
>
> --
> ISHIKAWA Mutsumi
> <ishikawa@linux.or.jp>, <ishikawa@debian.org>, <ishikawa@netvillage.co.jp>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix
2003-02-11 20:06 ` Justin T. Gibbs
@ 2003-02-11 20:21 ` Christoph Hellwig
2003-02-11 20:36 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2003-02-11 20:21 UTC (permalink / raw)
To: Justin T. Gibbs; +Cc: ISHIKAWA Mutsumi, jejb, linux-kernel
On Tue, Feb 11, 2003 at 01:06:41PM -0700, Justin T. Gibbs wrote:
> > This patch will fix two problems.
> >
> > fix build problem related scsi_cmnd changes
>
> The aic7xxx driver has one place that missed the conversion too.
> Since the cmd->lun field is no longer filled in, why hasn't the
> field been removed from the cmd structure? That would make it
> easy to catch these kinds of bugs.
I don't think that was intentional. I'll submit a patch to remove it ASAP.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix
2003-02-11 20:21 ` Christoph Hellwig
@ 2003-02-11 20:36 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2003-02-11 20:36 UTC (permalink / raw)
To: Justin T. Gibbs, ISHIKAWA Mutsumi, jejb, linux-kernel
On Tue, Feb 11, 2003 at 08:21:12PM +0000, Christoph Hellwig wrote:
> On Tue, Feb 11, 2003 at 01:06:41PM -0700, Justin T. Gibbs wrote:
> > > This patch will fix two problems.
> > >
> > > fix build problem related scsi_cmnd changes
> >
> > The aic7xxx driver has one place that missed the conversion too.
> > Since the cmd->lun field is no longer filled in, why hasn't the
> > field been removed from the cmd structure? That would make it
> > easy to catch these kinds of bugs.
>
> I don't think that was intentional. I'll submit a patch to remove it ASAP.
Actually it is already gone.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix
2003-02-11 18:25 [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix ISHIKAWA Mutsumi
2003-02-11 20:06 ` Justin T. Gibbs
@ 2003-02-11 20:52 ` James Bottomley
1 sibling, 0 replies; 5+ messages in thread
From: James Bottomley @ 2003-02-11 20:52 UTC (permalink / raw)
To: ISHIKAWA Mutsumi; +Cc: jejb, gibbs, linux-kernel
On Tue, 2003-02-11 at 12:25, ISHIKAWA Mutsumi wrote:
>
> This patch will fix two problems.
The first one I already have from Doug Gilbert. I'll add the second.
James
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-02-11 20:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-11 18:25 [PATCH 2.5.60 aic79xx] aic79xx build and lun detect problem fix ISHIKAWA Mutsumi
2003-02-11 20:06 ` Justin T. Gibbs
2003-02-11 20:21 ` Christoph Hellwig
2003-02-11 20:36 ` Christoph Hellwig
2003-02-11 20:52 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).