* [PATCH] Fix breakage caused by spelling 'fix'
@ 2003-03-06 21:41 Michael Hayes
2003-03-06 21:57 ` Linus Torvalds
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Michael Hayes @ 2003-03-06 21:41 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
This fixes a spelling "fix" that resulted in a compile error.
With apologies to Russell King.
diff -ur a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
--- a/include/asm-arm/proc-fns.h Tue Mar 4 19:29:20 2003
+++ b/include/asm-arm/proc-fns.h Thu Mar 6 11:46:15 2003
@@ -125,7 +125,7 @@
#if 0
* The following is to fool mkdep into generating the correct
- * dependencies. Without this, it can't figure out that this
+ * dependencies. Without this, it cant figure out that this
* file does indeed depend on the cpu-*.h files.
#include <asm/cpu-single.h>
#include <asm/cpu-multi26.h>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Fix breakage caused by spelling 'fix'
2003-03-06 21:41 [PATCH] Fix breakage caused by spelling 'fix' Michael Hayes
@ 2003-03-06 21:57 ` Linus Torvalds
2003-03-06 22:37 ` Steven Cole
2003-03-06 21:59 ` Marc-Christian Petersen
2003-03-06 22:27 ` Russell King
2 siblings, 1 reply; 8+ messages in thread
From: Linus Torvalds @ 2003-03-06 21:57 UTC (permalink / raw)
To: Michael Hayes; +Cc: linux-kernel
On Thu, 6 Mar 2003, Michael Hayes wrote:
>
> This fixes a spelling "fix" that resulted in a compile error.
>
> With apologies to Russell King.
Ugh, please make things like this just write out the full non-contracted
thing. Ie "cannot" is a perfectly fine word, we don't need to force
spelling errors.
Linus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fix breakage caused by spelling 'fix'
2003-03-06 21:57 ` Linus Torvalds
@ 2003-03-06 22:37 ` Steven Cole
0 siblings, 0 replies; 8+ messages in thread
From: Steven Cole @ 2003-03-06 22:37 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Michael Hayes, Linux Kernel
On Thu, 2003-03-06 at 14:57, Linus Torvalds wrote:
>
> On Thu, 6 Mar 2003, Michael Hayes wrote:
> >
> > This fixes a spelling "fix" that resulted in a compile error.
> >
> > With apologies to Russell King.
>
> Ugh, please make things like this just write out the full non-contracted
> thing. Ie "cannot" is a perfectly fine word, we don't need to force
> spelling errors.
>
> Linus
For yet another alternative:
[steven@spc9 steven]$ cat -n hello.c
1 #if 0
2 /* This won't break anything */
3 #include <bogus.h>
4 #endif
5
6 #if 0
7 * This won't compile
8 #include <missing.h>
9 #endif
10
11 #include <stdio.h>
12 int main()
13 {
14 printf("Hello world!\n");
15 }
[steven@spc9 steven]$ cc -c hello.c
hello.c:7:11: missing terminating ' character
--- linux-2.5.64/include/asm-arm/proc-fns.h.orig Thu Mar 6 15:19:17 2003
+++ linux-2.5.64/include/asm-arm/proc-fns.h Thu Mar 6 15:20:13 2003
@@ -124,9 +124,9 @@
#endif /* __KERNEL__ */
#if 0
- * The following is to fool mkdep into generating the correct
- * dependencies. Without this, it can't figure out that this
- * file does indeed depend on the cpu-*.h files.
+/* The following is to fool mkdep into generating the correct */
+/* dependencies. Without this, it can't figure out that this */
+/* file does indeed depend on the cpu-*.h files. */
#include <asm/cpu-single.h>
#include <asm/cpu-multi26.h>
#include <asm/cpu-multi32.h>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fix breakage caused by spelling 'fix'
2003-03-06 21:41 [PATCH] Fix breakage caused by spelling 'fix' Michael Hayes
2003-03-06 21:57 ` Linus Torvalds
@ 2003-03-06 21:59 ` Marc-Christian Petersen
2003-03-06 22:28 ` John Bradford
2003-03-06 22:27 ` Russell King
2 siblings, 1 reply; 8+ messages in thread
From: Marc-Christian Petersen @ 2003-03-06 21:59 UTC (permalink / raw)
To: Michael Hayes, linux-kernel; +Cc: torvalds
On Thursday 06 March 2003 22:41, Michael Hayes wrote:
Hi Michael,
> This fixes a spelling "fix" that resulted in a compile error.
> With apologies to Russell King.
> diff -ur a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
> --- a/include/asm-arm/proc-fns.h Tue Mar 4 19:29:20 2003
> +++ b/include/asm-arm/proc-fns.h Thu Mar 6 11:46:15 2003
> @@ -125,7 +125,7 @@
>
> #if 0
> * The following is to fool mkdep into generating the correct
> - * dependencies. Without this, it can't figure out that this
> + * dependencies. Without this, it cant figure out that this
A spelling fix should be a right spelling fix ;)
So either "cannot" or "can not" but not "cant" :)
ciao, Marc
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fix breakage caused by spelling 'fix'
2003-03-06 21:59 ` Marc-Christian Petersen
@ 2003-03-06 22:28 ` John Bradford
2003-03-06 22:48 ` Tomas Szepe
0 siblings, 1 reply; 8+ messages in thread
From: John Bradford @ 2003-03-06 22:28 UTC (permalink / raw)
To: Marc-Christian Petersen; +Cc: mike, linux-kernel, torvalds
> > This fixes a spelling "fix" that resulted in a compile error.
> > With apologies to Russell King.
> > diff -ur a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
> > --- a/include/asm-arm/proc-fns.h Tue Mar 4 19:29:20 2003
> > +++ b/include/asm-arm/proc-fns.h Thu Mar 6 11:46:15 2003
> > @@ -125,7 +125,7 @@
> >
> > #if 0
> > * The following is to fool mkdep into generating the correct
> > - * dependencies. Without this, it can't figure out that this
> > + * dependencies. Without this, it cant figure out that this
> A spelling fix should be a right spelling fix ;)
>
> So either "cannot" or "can not" but not "cant" :)
"Can not" is technically wrong.
http://marc.theaimsgroup.com/?l=linux-kernel&m=104691562715435&w=2
I also fell in to this trap.
John.
^ permalink raw reply [flat|nested] 8+ messages in thread
* re: [PATCH] Fix breakage caused by spelling 'fix'
2003-03-06 22:28 ` John Bradford
@ 2003-03-06 22:48 ` Tomas Szepe
0 siblings, 0 replies; 8+ messages in thread
From: Tomas Szepe @ 2003-03-06 22:48 UTC (permalink / raw)
To: John Bradford; +Cc: Marc-Christian Petersen, mike, linux-kernel, torvalds
> [john@grabjohn.com]
>
> > > This fixes a spelling "fix" that resulted in a compile error.
> > > With apologies to Russell King.
> > > diff -ur a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
> > > --- a/include/asm-arm/proc-fns.h Tue Mar 4 19:29:20 2003
> > > +++ b/include/asm-arm/proc-fns.h Thu Mar 6 11:46:15 2003
> > > @@ -125,7 +125,7 @@
> > >
> > > #if 0
> > > * The following is to fool mkdep into generating the correct
> > > - * dependencies. Without this, it can't figure out that this
> > > + * dependencies. Without this, it cant figure out that this
> > A spelling fix should be a right spelling fix ;)
> >
> > So either "cannot" or "can not" but not "cant" :)
>
> "Can not" is technically wrong.
While "can not" is not necessarily bad English, it's uncommon
and should probably be avoided, because its use might produce
sentences ambivalent in meaning.
<quote>
Can/could: modal auxiliary verbs --
...
h/ contracted negative forms are "can't" and "couldn't."
Cannot is usually written as one word.
</quote>
Swan, Michael: Practical English Usage
Oxford University Press, Second Edition, 1995
p. 104, item 122
--
Tomas Szepe <szepe@pinerecords.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fix breakage caused by spelling 'fix'
2003-03-06 21:41 [PATCH] Fix breakage caused by spelling 'fix' Michael Hayes
2003-03-06 21:57 ` Linus Torvalds
2003-03-06 21:59 ` Marc-Christian Petersen
@ 2003-03-06 22:27 ` Russell King
2 siblings, 0 replies; 8+ messages in thread
From: Russell King @ 2003-03-06 22:27 UTC (permalink / raw)
To: Michael Hayes; +Cc: linux-kernel, torvalds
On Thu, Mar 06, 2003 at 01:41:35PM -0800, Michael Hayes wrote:
> This fixes a spelling "fix" that resulted in a compile error.
>
> With apologies to Russell King.
Don't bother - its gone in my BK tree, which I'm going to send a request
to Linus to pull shortly.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fix breakage caused by spelling 'fix'
@ 2003-03-06 22:09 Michael Hayes
0 siblings, 0 replies; 8+ messages in thread
From: Michael Hayes @ 2003-03-06 22:09 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
On Thu, 6 Mar 2003, Linus Torvalds wrote:
> On Thu, 6 Mar 2003, Michael Hayes wrote:
> >
> > This fixes a spelling "fix" that resulted in a compile error.
> >
> > With apologies to Russell King.
>
> Ugh, please make things like this just write out the full non-contracted
> thing. Ie "cannot" is a perfectly fine word, we don't need to force
> spelling errors.
Nice to see that _someone_ cares :-)
Okay, here it is again with "cannot".
diff -ur a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
--- a/include/asm-arm/proc-fns.h Tue Mar 4 19:29:20 2003
+++ b/include/asm-arm/proc-fns.h Thu Mar 6 14:03:14 2003
@@ -125,7 +125,7 @@
#if 0
* The following is to fool mkdep into generating the correct
- * dependencies. Without this, it can't figure out that this
+ * dependencies. Without this, it cannot figure out that this
* file does indeed depend on the cpu-*.h files.
#include <asm/cpu-single.h>
#include <asm/cpu-multi26.h>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2003-03-06 22:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-06 21:41 [PATCH] Fix breakage caused by spelling 'fix' Michael Hayes
2003-03-06 21:57 ` Linus Torvalds
2003-03-06 22:37 ` Steven Cole
2003-03-06 21:59 ` Marc-Christian Petersen
2003-03-06 22:28 ` John Bradford
2003-03-06 22:48 ` Tomas Szepe
2003-03-06 22:27 ` Russell King
2003-03-06 22:09 Michael Hayes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).