From: Sameer Pujar <spujar@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <perex@perex.cz>,
<tiwai@suse.com>, <robh+dt@kernel.org>
Cc: <spujar@nvidia.com>, <broonie@kernel.org>, <lgirdwood@gmail.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sharadg@nvidia.com>, <mkumard@nvidia.com>,
<viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
<dramesh@nvidia.com>, <atalambedu@nvidia.com>
Subject: Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver
Date: Tue, 4 Feb 2020 10:04:37 +0530 [thread overview]
Message-ID: <104d2019-6505-09b1-0e9f-bcfcdd70c18e@nvidia.com> (raw)
In-Reply-To: <bd802f93-dd03-f39d-86e1-39f8571bbbb0@gmail.com>
On 1/30/2020 10:39 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 30.01.2020 13:33, Sameer Pujar пишет:
> ...
>> + ret = devm_snd_soc_register_component(&pdev->dev,
>> + ahub->soc_data->cmpnt_drv,
>> + ahub->soc_data->dai_drv,
>> + ahub->soc_data->num_dais);
>> + if (ret < 0) {
>> + dev_err(&pdev->dev, "failed to register component, err: %d\n",
>> + ret);
>> + return ret;
>> + }
> In the the patch #4 ("ASoC: tegra: add Tegra210 based I2S driver") I see
> the following:
>
> ret = devm_snd_soc_register_component(dev, &tegra210_i2s_cmpnt,
> tegra210_i2s_dais,
> ARRAY_SIZE(tegra210_i2s_dais));
> if (ret != 0) {
> dev_err(dev, "can't register I2S component, err: %d\n", ret);
> return ret;
> }
>
> Please be consistent in regards to errors checking. The correct variant
> should be: if (ret != 0). Usually error codes are a negative value, but
> it is much safer to check whether value isn't 0 in all cases where
> positive value isn't expected to happen.
yes "if (ret)" is good enough in such cases.
>
> I'd also recommend to rename all "ret" variables to "err" everywhere in
> the code where returned value is used only for errors checking. This
> will make code more explicit, and hence, easier to read and follow.
OK, I will update it to 'err' for better.
>
> So, it will be nicer to write it as:
>
> err = devm_snd_soc_register_component(&pdev->dev,
> ahub->soc_data->cmpnt_drv,
> ahub->soc_data->dai_drv,
> ahub->soc_data->num_dais);
> if (err) {
> dev_err(&pdev->dev, "failed to register component: %d\n", err);
> return err;
> }
next prev parent reply other threads:[~2020-02-04 4:34 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 10:33 [PATCH v2 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-03 20:19 ` Dmitry Osipenko
2020-02-04 4:24 ` Sameer Pujar
2020-02-06 18:10 ` Rob Herring
2020-02-10 11:30 ` Sameer Pujar
2020-02-11 18:15 ` Rob Herring
2020-01-30 10:33 ` [PATCH v2 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-05 17:02 ` Dmitry Osipenko
2020-02-06 11:56 ` Sameer Pujar
2020-02-06 16:49 ` Dmitry Osipenko
2020-02-07 11:03 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-06 16:53 ` Dmitry Osipenko
2020-02-07 11:06 ` Sameer Pujar
2020-02-08 16:19 ` Dmitry Osipenko
2020-01-30 10:33 ` [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-06 16:59 ` Dmitry Osipenko
2020-02-06 17:06 ` David Laight
2020-02-07 11:23 ` Sameer Pujar
2020-02-07 11:24 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-30 16:22 ` Dmitry Osipenko
2020-02-04 4:29 ` Sameer Pujar
2020-01-30 17:09 ` Dmitry Osipenko
2020-01-30 17:18 ` Dmitry Osipenko
2020-02-04 4:35 ` Sameer Pujar
2020-02-04 4:34 ` Sameer Pujar [this message]
2020-01-30 17:25 ` Dmitry Osipenko
2020-01-31 3:12 ` Sameer Pujar
2020-01-31 14:34 ` Dmitry Osipenko
2020-02-04 4:36 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-06 17:15 ` Dmitry Osipenko
2020-02-07 11:26 ` Sameer Pujar
2020-02-07 18:22 ` Dmitry Osipenko
2020-02-10 11:15 ` Sameer Pujar
2020-02-10 12:22 ` Jon Hunter
2020-02-10 14:49 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 9/9] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-06 17:36 ` [PATCH v2 0/9] add ASoC components for AHUB Dmitry Osipenko
2020-02-07 11:30 ` Sameer Pujar
2020-02-07 18:25 ` Dmitry Osipenko
2020-02-10 11:22 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=104d2019-6505-09b1-0e9f-bcfcdd70c18e@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).