From: Jon Hunter <jonathanh@nvidia.com>
To: Sameer Pujar <spujar@nvidia.com>, Dmitry Osipenko <digetx@gmail.com>
Cc: <perex@perex.cz>, <tiwai@suse.com>, <robh+dt@kernel.org>,
<broonie@kernel.org>, <lgirdwood@gmail.com>,
<thierry.reding@gmail.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
<atalambedu@nvidia.com>
Subject: Re: [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver
Date: Mon, 10 Feb 2020 12:22:56 +0000 [thread overview]
Message-ID: <4c75fc51-fbfd-158f-a096-d4f178921ee3@nvidia.com> (raw)
In-Reply-To: <3c19ef99-8051-76f7-a4d6-0d61182fe6e4@nvidia.com>
On 10/02/2020 11:15, Sameer Pujar wrote:
>
>
> On 2/7/2020 11:52 PM, Dmitry Osipenko wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> 07.02.2020 14:26, Sameer Pujar пишет:
>>>
>>> On 2/6/2020 10:45 PM, Dmitry Osipenko wrote:
>>>> External email: Use caution opening links or attachments
>>>>
>>>>
>>>> 30.01.2020 13:33, Sameer Pujar пишет:
>>>>> +static const struct dev_pm_ops tegra186_dspk_pm_ops = {
>>>>> + SET_RUNTIME_PM_OPS(tegra186_dspk_runtime_suspend,
>>>>> + tegra186_dspk_runtime_resume, NULL)
>>>>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
>>>>> + pm_runtime_force_resume)
>>>>> +};
>>>> Could you please explain why drivers need the "late" system sleep?
>>> It was done to ensure core drivers are suspended first and defer the
>>> codec driver suspend
>> Suspend order is opposite to the drivers registration order. If there is
>> no real problem with that, then you should use the default suspend
>
>> level. Please don't try to fix a non-existent problems.
>
> No. This was done specifically to allow sound core to first stop any
> ongoing audio activity during normal suspend and ensure a safe suspend
> of AHUB devices by doing a LATE suspend.
What Dmitry is saying is that if the DSPK driver is registered after the
sound core then we will not need to suspend in the late phase. The DSPK
device should only be registered once the sound core is loaded, because
otherwise we should fail to register it with the sound core. So I don't
think we need this to be late afterall.
Jon
--
nvpublic
next prev parent reply other threads:[~2020-02-10 12:23 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 10:33 [PATCH v2 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-03 20:19 ` Dmitry Osipenko
2020-02-04 4:24 ` Sameer Pujar
2020-02-06 18:10 ` Rob Herring
2020-02-10 11:30 ` Sameer Pujar
2020-02-11 18:15 ` Rob Herring
2020-01-30 10:33 ` [PATCH v2 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-05 17:02 ` Dmitry Osipenko
2020-02-06 11:56 ` Sameer Pujar
2020-02-06 16:49 ` Dmitry Osipenko
2020-02-07 11:03 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-06 16:53 ` Dmitry Osipenko
2020-02-07 11:06 ` Sameer Pujar
2020-02-08 16:19 ` Dmitry Osipenko
2020-01-30 10:33 ` [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-06 16:59 ` Dmitry Osipenko
2020-02-06 17:06 ` David Laight
2020-02-07 11:23 ` Sameer Pujar
2020-02-07 11:24 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-30 16:22 ` Dmitry Osipenko
2020-02-04 4:29 ` Sameer Pujar
2020-01-30 17:09 ` Dmitry Osipenko
2020-01-30 17:18 ` Dmitry Osipenko
2020-02-04 4:35 ` Sameer Pujar
2020-02-04 4:34 ` Sameer Pujar
2020-01-30 17:25 ` Dmitry Osipenko
2020-01-31 3:12 ` Sameer Pujar
2020-01-31 14:34 ` Dmitry Osipenko
2020-02-04 4:36 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-06 17:15 ` Dmitry Osipenko
2020-02-07 11:26 ` Sameer Pujar
2020-02-07 18:22 ` Dmitry Osipenko
2020-02-10 11:15 ` Sameer Pujar
2020-02-10 12:22 ` Jon Hunter [this message]
2020-02-10 14:49 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 9/9] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-06 17:36 ` [PATCH v2 0/9] add ASoC components for AHUB Dmitry Osipenko
2020-02-07 11:30 ` Sameer Pujar
2020-02-07 18:25 ` Dmitry Osipenko
2020-02-10 11:22 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c75fc51-fbfd-158f-a096-d4f178921ee3@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dramesh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).