From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Mukker, Atul" <atulm@lsil.com>,
"'alan@redhat.com'" <alan@redhat.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'linux-megaraid-devel@dell.com'" <linux-megaraid-devel@dell.com>,
"'linux-megaraid-announce@dell.com'"
<linux-megaraid-announce@dell.com>
Subject: Re: [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels
Date: 17 Apr 2003 12:25:44 -0500 [thread overview]
Message-ID: <1050600346.1784.98.camel@mulgrave> (raw)
In-Reply-To: <20030417133820.A12503@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
OK, I think the attached patch fixes the try_module_get problem and also
sweeps up a compile warning issue I ran into on pa-risc.
Does this look OK to everyone?
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain, Size: 1715 bytes --]
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1044 -> 1.1046
# drivers/scsi/megaraid.c 1.38 -> 1.40
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/04/17 jejb@raven.il.steeleye.com 1.1045
# Fix megaraid compile warnings
# --------------------------------------------
# 03/04/17 jejb@raven.il.steeleye.com 1.1046
# Fix megaraid module ownership
#
# Move to using the .owner field of fops
# --------------------------------------------
#
diff -Nru a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
--- a/drivers/scsi/megaraid.c Thu Apr 17 12:23:35 2003
+++ b/drivers/scsi/megaraid.c Thu Apr 17 12:23:35 2003
@@ -34,6 +34,7 @@
#include <linux/fs.h>
#include <linux/blk.h>
#include <asm/uaccess.h>
+#include <asm/io.h>
#include <linux/delay.h>
#include <linux/reboot.h>
#include <linux/module.h>
@@ -87,9 +88,9 @@
* The File Operations structure for the serial/ioctl interface of the driver
*/
static struct file_operations megadev_fops = {
+ .owner = THIS_MODULE,
.ioctl = megadev_ioctl,
.open = megadev_open,
- .release = megadev_close,
};
/*
@@ -4039,9 +4040,6 @@
*/
if( !capable(CAP_SYS_ADMIN) ) return -EACCES;
- if (!try_module_get(THIS_MODULE)) {
- return -ENXIO;
- }
return 0;
}
@@ -4635,14 +4633,6 @@
}
}
- return 0;
-}
-
-
-static int
-megadev_close (struct inode *inode, struct file *filep)
-{
- module_put(THIS_MODULE);
return 0;
}
next prev parent reply other threads:[~2003-04-17 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-16 20:34 [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels Mukker, Atul
2003-04-17 12:38 ` Christoph Hellwig
2003-04-17 12:52 ` Alan Cox
2003-04-17 12:57 ` Christoph Hellwig
2003-04-17 13:23 ` Alan Cox
2003-04-17 13:56 ` Christoph Hellwig
2003-04-17 14:41 ` James Bottomley
2003-04-17 17:25 ` James Bottomley [this message]
2003-04-25 23:04 Mukker, Atul
2003-04-26 19:42 Mukker, Atul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050600346.1784.98.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=alan@redhat.com \
--cc=atulm@lsil.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-megaraid-announce@dell.com \
--cc=linux-megaraid-devel@dell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).