From: Christoph Hellwig <hch@infradead.org>
To: Alan Cox <alan@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Mukker Atul <atulm@lsil.com>,
"'James.Bottomley@steeleye.com'" <James.Bottomley@steeleye.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'linux-megaraid-devel@dell.com'" <linux-megaraid-devel@dell.com>,
"'linux-megaraid-announce@dell.com'"
<linux-megaraid-announce@dell.com>
Subject: Re: [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels
Date: Thu, 17 Apr 2003 13:57:19 +0100 [thread overview]
Message-ID: <20030417135719.A13189@infradead.org> (raw)
In-Reply-To: <200304171252.h3HCqG909973@devserv.devel.redhat.com>; from alan@redhat.com on Thu, Apr 17, 2003 at 08:52:16AM -0400
On Thu, Apr 17, 2003 at 08:52:16AM -0400, Alan Cox wrote:
> a) megaraid always used a set of basic typedefs. Seems to be your personal
> view not general comment
At least Linus seems to share my opinion :)
> > Do you really need this? Why can you use
> > struct device_driver->shutdown?
>
> Not on 2.2
This is a 2.5-only driver (in fact a 2.5 only patch against a 2.4 driver)
> > return FALSE;
> >
> > Please don't use TRUE/FALSE but 1/0 directly.
>
> TRUE/FALSE is IMHO perfectly clear
It's clear, but Linux kernel code avoids it usually. I'm
currently getting rid of it in the scsi headers so it's a good idea
to avoid it in new drivers.
next prev parent reply other threads:[~2003-04-17 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-16 20:34 [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels Mukker, Atul
2003-04-17 12:38 ` Christoph Hellwig
2003-04-17 12:52 ` Alan Cox
2003-04-17 12:57 ` Christoph Hellwig [this message]
2003-04-17 13:23 ` Alan Cox
2003-04-17 13:56 ` Christoph Hellwig
2003-04-17 14:41 ` James Bottomley
2003-04-17 17:25 ` James Bottomley
2003-04-25 23:04 Mukker, Atul
2003-04-26 19:42 Mukker, Atul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030417135719.A13189@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=alan@redhat.com \
--cc=atulm@lsil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-megaraid-announce@dell.com \
--cc=linux-megaraid-devel@dell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).