[TRIVIAL][PATCH 2.4] Help dummies configure QoS

[TRIVIAL][PATCH 2.4] Help dummies configure QoS

[Dave Maietta]

In the packet schedulers section of the config scripts, neither the
Ingress Qdisc nor any comment about its existence are displayed in
Menuconfig if some dependencies are not met in other places.  To help
dummies like me know that it's there, please consider the following
patch:

--- linux/net/sched/Config.in.orig	2003-05-04 18:50:54.000000000 -0400
+++ linux/net/sched/Config.in	2003-05-04 18:43:32.000000000 -0400
@@ -16,9 +16,6 @@
 tristate '  TBF queue' CONFIG_NET_SCH_TBF
 tristate '  GRED queue' CONFIG_NET_SCH_GRED
 tristate '  Diffserv field marker' CONFIG_NET_SCH_DSMARK
-if [ "$CONFIG_NETFILTER" = "y" ]; then
-   tristate '  Ingress Qdisc' CONFIG_NET_SCH_INGRESS
-fi
 bool '  QoS support' CONFIG_NET_QOS
 if [ "$CONFIG_NET_QOS" = "y" ]; then
    bool '    Rate estimator' CONFIG_NET_ESTIMATOR
@@ -38,4 +35,12 @@
       bool '    Traffic policing (needed for in/egress)'
CONFIG_NET_CLS_POLICE
    fi
 fi
+if [ "$CONFIG_NETFILTER" = "n" -o "$CONFIG_NET_QOS" = "n" -o \
+   "$CONFIG_NET_CLS" = "n" -o "$CONFIG_NET_CLS_POLICE" = "n" ]; then
+   comment '  Ingress Qdisc:  To enable, please include'
+   comment '    Network Packet Filtering, QoS Support,'
+   comment '    and Packet Classifier API/Traffic Policing'
+else
+   tristate '  Ingress Qdisc' CONFIG_NET_SCH_INGRESS
+fi
 


Thanks,
Dave Maietta
dave$qix,net

Re: [TRIVIAL][PATCH 2.4] Help dummies configure QoS

[Rusty Russell]

In message <1052092397.5844.33.camel@hell> you write:
> In the packet schedulers section of the config scripts, neither the
> Ingress Qdisc nor any comment about its existence are displayed in
> Menuconfig if some dependencies are not met in other places.  To help
> dummies like me know that it's there, please consider the following
> patch:

Better is to put comments in CONFIG_NETFILTER, I think.

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.