From: Keith Mannthey <kmannth@us.ibm.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [RFC][Patch] fix for irq_affinity_write_proc v2.5
Date: 06 May 2003 12:03:08 -0700 [thread overview]
Message-ID: <1052247789.16886.261.camel@dyn9-47-17-180.beaverton.ibm.com> (raw)
Hello,
irq_affinity_write_proc currently directly calls set_ioapic_affinity
which writes to the ioapic. This undermines the work done by kirqd by
writing a cpu mask directly to the ioapic. I propose the following patch
to tie the /proc affinity writes into the same code path as kirqd.
Kirqd will enforce the affinity requested by the user.
Keith Mannthey
diff -urN linux-2.5.68/arch/i386/kernel/irq.c linux-2.5.68-procfix/arch/i386/kernel/irq.c
--- linux-2.5.68/arch/i386/kernel/irq.c Sat Apr 19 19:48:50 2003
+++ linux-2.5.68-procfix/arch/i386/kernel/irq.c Thu May 8 13:47:38 2003
@@ -871,8 +871,11 @@
return -EINVAL;
irq_affinity[irq] = new_value;
- irq_desc[irq].handler->set_affinity(irq, new_value);
-
+ if (irqbalance_disabled)
+ irq_desc[irq].handler->set_affinity(irq, new_value);
+ else
+ do_irq_balance();
+
return full_count;
}
next reply other threads:[~2003-05-06 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 19:03 Keith Mannthey [this message]
2003-05-06 19:54 ` [RFC][Patch] fix for irq_affinity_write_proc v2.5 Alan Cox
2003-05-06 21:58 ` Keith Mannthey
2003-05-07 2:27 ` William Lee Irwin III
2003-05-07 12:16 ` Alan Cox
2003-05-07 18:12 ` Keith Mannthey
2003-05-07 3:56 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052247789.16886.261.camel@dyn9-47-17-180.beaverton.ibm.com \
--to=kmannth@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).