linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, Keith Mannthey <kmannth@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][Patch] fix for irq_affinity_write_proc v2.5
Date: Tue, 06 May 2003 20:56:54 -0700	[thread overview]
Message-ID: <2770000.1052279813@[10.10.2.4]> (raw)
In-Reply-To: <1052250874.1202.162.camel@dhcp22.swansea.linux.org.uk>

>>   irq_affinity_write_proc currently directly calls set_ioapic_affinity
>> which writes to the ioapic.  This undermines the work done by kirqd by
>> writing a cpu mask directly to the ioapic. I propose the following patch
>> to tie the /proc affinity writes into the same code path as kirqd. 
>> Kirqd will enforce the affinity requested by the user.   
> 
> Why should the kernel be enforcing policy here. You have to be root to 
> do this, and root should have the ability to configure apparently stupid
> things because they may find them useful.

Whilst in general, I'd agree, in this case it makes no sense - there are
two masks set: the irqbalance mask, and the apicid mask. If irqbalance
is on, setting the apicid mask doesn't really do anything, because 
irqbalance is going to reset it dynamically very shortly afterwards
anyway. It's hard to imagine how that might be useful ;-)

It might conceivably be useful to disable irqbalance dynamically, if that's
what you mean, but that shouldn't be the default behaviour, I think. 
Keith already a nice simple patch to make it a config option ... doing it 
dynamically is a different project, IMHO, and one of questionable utility 
to anyone not capable of coding it themselves ;-)

M.


      parent reply	other threads:[~2003-05-07  5:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-06 19:03 [RFC][Patch] fix for irq_affinity_write_proc v2.5 Keith Mannthey
2003-05-06 19:54 ` Alan Cox
2003-05-06 21:58   ` Keith Mannthey
2003-05-07  2:27   ` William Lee Irwin III
2003-05-07 12:16     ` Alan Cox
2003-05-07 18:12       ` Keith Mannthey
2003-05-07  3:56   ` Martin J. Bligh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='2770000.1052279813@[10.10.2.4]' \
    --to=mbligh@aracnet.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=kmannth@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).