* [PATCH 2.5.69 1/2] i_size atomic access
@ 2003-05-08 23:29 Daniel McNeil
2003-05-08 23:32 ` [PATCH 2.5.69 1/2] i_size atomic access (again) Daniel McNeil
0 siblings, 1 reply; 2+ messages in thread
From: Daniel McNeil @ 2003-05-08 23:29 UTC (permalink / raw)
To: Andrew Morton, Andrea Arcangeli, Linux Kernel Mailing List
This adds a sequence counter only version of the reader/writer
consistent mechanism to seqlock.h This is used in the second
part of this patch give atomic access to i_size.
re-diff against 2.5.69.
The patch is also available for download from OSDL's patch lifecycle
manager (PLM):
http://www.osdl.org/cgi-bin/plm?module=patch_info&patch_id=1834
--
Daniel McNeil <daniel@osdl.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2.5.69 1/2] i_size atomic access (again)
2003-05-08 23:29 [PATCH 2.5.69 1/2] i_size atomic access Daniel McNeil
@ 2003-05-08 23:32 ` Daniel McNeil
0 siblings, 0 replies; 2+ messages in thread
From: Daniel McNeil @ 2003-05-08 23:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andrea Arcangeli, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
With the patch attached.
On Thu, 2003-05-08 at 16:29, Daniel McNeil wrote:
> This adds a sequence counter only version of the reader/writer
> consistent mechanism to seqlock.h This is used in the second
> part of this patch give atomic access to i_size.
>
> re-diff against 2.5.69.
>
> The patch is also available for download from OSDL's patch lifecycle
> manager (PLM):
>
> http://www.osdl.org/cgi-bin/plm?module=patch_info&patch_id=1834
--
Daniel McNeil <daniel@osdl.org>
[-- Attachment #2: patch-2.5.69-isize.1 --]
[-- Type: text/x-patch, Size: 1603 bytes --]
diff -rupN -X /home/daniel/dontdiff linux-2.5.69/include/linux/seqlock.h linux-2.5.69-isize/include/linux/seqlock.h
--- linux-2.5.69/include/linux/seqlock.h Sun May 4 16:53:14 2003
+++ linux-2.5.69-isize/include/linux/seqlock.h Wed May 7 16:00:25 2003
@@ -94,6 +94,57 @@ static inline int read_seqretry(const se
return (iv & 1) | (sl->sequence ^ iv);
}
+
+/*
+ * Version using sequence counter only.
+ * This can be used when code has its own mutex protecting the
+ * updating starting before the write_seqcntbeqin() and ending
+ * after the write_seqcntend().
+ */
+
+typedef struct seqcnt {
+ unsigned sequence;
+} seqcnt_t;
+
+#define SEQCNT_ZERO { 0 }
+#define seqcnt_init(x) do { *(x) = (seqcnt_t) SEQCNT_ZERO; } while (0)
+
+/* Start of read using pointer to a sequence counter only. */
+static inline unsigned read_seqcntbegin(const seqcnt_t *s)
+{
+ unsigned ret = s->sequence;
+ smp_rmb();
+ return ret;
+}
+
+/* Test if reader processed invalid data.
+ * Equivalent to: iv is odd or sequence number has changed.
+ * (iv & 1) || (*s != iv)
+ * Using xor saves one conditional branch.
+ */
+static inline int read_seqcntretry(const seqcnt_t *s, unsigned iv)
+{
+ smp_rmb();
+ return (iv & 1) | (s->sequence ^ iv);
+}
+
+
+/*
+ * Sequence counter only version assumes that callers are using their
+ * own mutexing.
+ */
+static inline void write_seqcntbegin(seqcnt_t *s)
+{
+ s->sequence++;
+ smp_wmb();
+}
+
+static inline void write_seqcntend(seqcnt_t *s)
+{
+ smp_wmb();
+ s->sequence++;
+}
+
/*
* Possible sw/hw IRQ protected versions of the interfaces.
*/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-08 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-08 23:29 [PATCH 2.5.69 1/2] i_size atomic access Daniel McNeil
2003-05-08 23:32 ` [PATCH 2.5.69 1/2] i_size atomic access (again) Daniel McNeil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).