linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix for kallsyms module symbol resolution problem
Date: 29 Jun 2003 22:13:08 -0500	[thread overview]
Message-ID: <1056942790.10904.324.camel@mulgrave> (raw)
In-Reply-To: <20030630025802.F2F432C232@lists.samba.org>

On Sun, 2003-06-29 at 21:06, Rusty Russell wrote:
> Please test, because that's only one problem.
> 
> The other is that the module_text_address() returns true if the value
> is within the module, *not* just if it's within a function.  So you
> can get some noise there, too, on archs which don't do real
> backtracing.

Well, the fix is pretty cast iron in that it will print out the closest
symbol with a non null name (which has got to be better than printing an
empty string).  The routine length may still be wrong since the next
closest symbol may still be null.

However, that does bring me to another issue we have on parisc (the
problem traceback was actually from x86): our tool chain, for reasons
best known to itself, inserts local symbol names into the symbol table
section.  On parisc, we get rid of them again by throwing them out of
the symbol table section in module_finalize (which we shouldn't do,
since the pointers are constant).

Perhaps there should be a per-arch hook for purging the symbol tables of
irrelevant symbols before we do kallsyms lookups in it?

James



  reply	other threads:[~2003-06-30  3:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-28  3:26 [PATCH] fix for kallsyms module symbol resolution problem James Bottomley
2003-06-30  2:06 ` Rusty Russell
2003-06-30  3:13   ` James Bottomley [this message]
2003-06-30  6:17     ` Rusty Russell
2003-06-30 14:10       ` James Bottomley
2003-07-01  1:11         ` Rusty Russell
2003-07-01  2:24       ` James Bottomley
2003-07-01  4:58         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1056942790.10904.324.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=kai@tp1.ruhr-uni-bochum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).