From: James Bottomley <James.Bottomley@steeleye.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix for kallsyms module symbol resolution problem
Date: 30 Jun 2003 09:10:46 -0500 [thread overview]
Message-ID: <1056982249.2069.25.camel@mulgrave> (raw)
In-Reply-To: <20030630074948.8F43D2C0A7@lists.samba.org>
On Mon, 2003-06-30 at 01:17, Rusty Russell wrote:
> Yeah, but I was trying to get you to do more work. And if the names
> resulting are useless anyway, why apply the patch?
I noticed.
However, not printing empty names makes the trace a lot more useful.
Just doing a symbolic trace on modules on x86, I see pretty much the
correct call trace now.
But, I'll investigate and see if I can find a way of generically telling
if a particular symbol is useful or not.
> > Perhaps there should be a per-arch hook for purging the symbol tables of
> > irrelevant symbols before we do kallsyms lookups in it?
>
> I think you can do it easily in module_finalize... or if we were
> ambitious we'd extract only the function symbols rather than keeping
> the whole strtab and symtab.
Apart from the dubious writing to a const * pointer, yes I can (it's
what I'm doing now). There is some annoyance in that module_finalize
isn't told where the string or symbol tables are, so I have to find them
again.
James
next prev parent reply other threads:[~2003-06-30 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-28 3:26 [PATCH] fix for kallsyms module symbol resolution problem James Bottomley
2003-06-30 2:06 ` Rusty Russell
2003-06-30 3:13 ` James Bottomley
2003-06-30 6:17 ` Rusty Russell
2003-06-30 14:10 ` James Bottomley [this message]
2003-07-01 1:11 ` Rusty Russell
2003-07-01 2:24 ` James Bottomley
2003-07-01 4:58 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056982249.2069.25.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).