* [PATCH] nbd.c compile warning
@ 2003-07-12 14:50 Shane Shrybman
2003-07-13 17:16 ` Paul Clements
0 siblings, 1 reply; 4+ messages in thread
From: Shane Shrybman @ 2003-07-12 14:50 UTC (permalink / raw)
To: Paul.Clements; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Here is a patch to fix a compile warning from nbd.c. It has been compile
tested, ( I don't actually use nbd, yet). I have included the patch as
an attachment in case it gets mangled.
--- linux-2.5.75-mm1/drivers/block/nbd.c.orig Sat Jul 12 09:23:45 2003
+++ linux-2.5.75-mm1/drivers/block/nbd.c Sat Jul 12 09:45:06 2003
@@ -261,7 +261,7 @@
dprintk(DBG_TX, "%s: request %p: sending control
(%s@%llu,%luB)\n",
lo->disk->disk_name, req,
nbdcmd_to_ascii(nbd_cmd(req)),
- req->sector << 9, req->nr_sectors << 9);
+ (unsigned long long)req->sector << 9,
req->nr_sectors << 9);
result = sock_xmit(sock, 1, &request, sizeof(request),
(nbd_cmd(req) == NBD_CMD_WRITE)? MSG_MORE: 0);
if (result <= 0) {
Regards,
shane
[-- Attachment #2: nbd.compile.warning.diff --]
[-- Type: text/x-diff, Size: 531 bytes --]
--- linux-2.5.75-mm1/drivers/block/nbd.c.orig Sat Jul 12 09:23:45 2003
+++ linux-2.5.75-mm1/drivers/block/nbd.c Sat Jul 12 09:45:06 2003
@@ -261,7 +261,7 @@
dprintk(DBG_TX, "%s: request %p: sending control (%s@%llu,%luB)\n",
lo->disk->disk_name, req,
nbdcmd_to_ascii(nbd_cmd(req)),
- req->sector << 9, req->nr_sectors << 9);
+ (unsigned long long)req->sector << 9, req->nr_sectors << 9);
result = sock_xmit(sock, 1, &request, sizeof(request),
(nbd_cmd(req) == NBD_CMD_WRITE)? MSG_MORE: 0);
if (result <= 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nbd.c compile warning
2003-07-12 14:50 [PATCH] nbd.c compile warning Shane Shrybman
@ 2003-07-13 17:16 ` Paul Clements
0 siblings, 0 replies; 4+ messages in thread
From: Paul Clements @ 2003-07-13 17:16 UTC (permalink / raw)
To: Shane Shrybman; +Cc: Paul.Clements, linux-kernel
On 12 Jul 2003, Shane Shrybman wrote:
> Here is a patch to fix a compile warning from nbd.c. It has been compile
> tested, ( I don't actually use nbd, yet). I have included the patch as
> an attachment in case it gets mangled.
>
> --- linux-2.5.75-mm1/drivers/block/nbd.c.orig Sat Jul 12 09:23:45 2003
> +++ linux-2.5.75-mm1/drivers/block/nbd.c Sat Jul 12 09:45:06 2003
> @@ -261,7 +261,7 @@
> dprintk(DBG_TX, "%s: request %p: sending control
> (%s@%llu,%luB)\n",
> lo->disk->disk_name, req,
> nbdcmd_to_ascii(nbd_cmd(req)),
> - req->sector << 9, req->nr_sectors << 9);
> + (unsigned long long)req->sector << 9,
> req->nr_sectors << 9);
> result = sock_xmit(sock, 1, &request, sizeof(request),
> (nbd_cmd(req) == NBD_CMD_WRITE)? MSG_MORE: 0);
> if (result <= 0) {
>
Thanks, I'll send a patch on to Andrew Morton shortly.
--
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nbd.c compile warning
2003-07-12 17:04 Lou Langholtz
@ 2003-07-12 18:35 ` Shane Shrybman
0 siblings, 0 replies; 4+ messages in thread
From: Shane Shrybman @ 2003-07-12 18:35 UTC (permalink / raw)
To: Lou Langholtz; +Cc: linux-kernel, Andrew Morton, Paul Clements
On Sat, 2003-07-12 at 13:04, Lou Langholtz wrote:
> Do you have large block device support turned on or off in your kernel
> build options? I believe this compile warning came as a result of
# CONFIG_LBD is not set
> compiling without CONFIG_LBD - I hadn't tried building that way and
> would then have missed this problem. Just typecasting the result as your
> patch does should work correctly either way though. I'll make sure to
> pull it into my NBD sources but you will need to get Andrew Morton or
> Paul Clements to pick up the patch for it to move into the kernel distro
> stream. I've CC'd them on this message to help expedite this. Thanks!
>
Mr. Clements was cc'd on the original email as well. Thanks for looking
at the patch.
Regards,
shane
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] nbd.c compile warning
@ 2003-07-12 17:04 Lou Langholtz
2003-07-12 18:35 ` Shane Shrybman
0 siblings, 1 reply; 4+ messages in thread
From: Lou Langholtz @ 2003-07-12 17:04 UTC (permalink / raw)
To: shrybman; +Cc: linux-kernel, Andrew Morton, Paul Clements
Do you have large block device support turned on or off in your kernel
build options? I believe this compile warning came as a result of
compiling without CONFIG_LBD - I hadn't tried building that way and
would then have missed this problem. Just typecasting the result as your
patch does should work correctly either way though. I'll make sure to
pull it into my NBD sources but you will need to get Andrew Morton or
Paul Clements to pick up the patch for it to move into the kernel distro
stream. I've CC'd them on this message to help expedite this. Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-07-13 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-12 14:50 [PATCH] nbd.c compile warning Shane Shrybman
2003-07-13 17:16 ` Paul Clements
2003-07-12 17:04 Lou Langholtz
2003-07-12 18:35 ` Shane Shrybman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).