From: Jeremy Fitzhardinge <jeremy@goop.org>
To: maneesh@in.ibm.com
Cc: Andrew Morton <akpm@osdl.org>,
Dick Streefland <dick.streefland@xs4all.nl>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] autofs4 doesn't expire
Date: 05 Aug 2003 21:34:14 -0700 [thread overview]
Message-ID: <1060144454.18625.5.camel@ixodes.goop.org> (raw)
In-Reply-To: <20030806042853.GA1298@in.ibm.com>
On Tue, 2003-08-05 at 21:28, Maneesh Soni wrote:
> Sorry, I don't think it is correct. This code is called under dcache_lock,
> taken in is_tree_busy(). mntput() calls dput() and which can lead to deadlock.
Urk. On the other hand, it only calls dput if the refcount drops to
zero, which it can't because there's already a reference (hence the -2
in is_vfsmnt_tree_busy).
I'm not too keen on releasing dcache lock, since the whole point is to
keep the dcache tree stable while we traverse it.
> @@ -71,7 +74,8 @@ static int check_vfsmnt(struct vfsmount
> struct vfsmount *vfs = lookup_mnt(mnt, dentry);
>
> if (vfs && is_vfsmnt_tree_busy(vfs))
> - ret--;
> + ret = 0;
Erm, why?
J
next prev parent reply other threads:[~2003-08-06 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 22:16 [PATCH] autofs4 doesn't expire Dick Streefland
2003-08-05 23:49 ` Andrew Morton
2003-08-06 0:03 ` Jeremy Fitzhardinge
2003-08-06 4:28 ` Maneesh Soni
2003-08-06 4:34 ` Jeremy Fitzhardinge [this message]
2003-08-06 5:00 ` Maneesh Soni
2003-08-06 5:01 ` Jeremy Fitzhardinge
2003-08-06 5:08 ` Andrew Morton
2003-08-06 5:38 ` Maneesh Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060144454.18625.5.camel@ixodes.goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=dick.streefland@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).