From: Maneesh Soni <maneesh@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jeremy@goop.org, dick.streefland@xs4all.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] autofs4 doesn't expire
Date: Wed, 6 Aug 2003 11:08:07 +0530 [thread overview]
Message-ID: <20030806053807.GC1298@in.ibm.com> (raw)
In-Reply-To: <20030805220848.3ee1111a.akpm@osdl.org>
On Tue, Aug 05, 2003 at 10:08:48PM -0700, Andrew Morton wrote:
> Maneesh Soni <maneesh@in.ibm.com> wrote:
> >
> > + if (vfs) {
> > + if (is_vfsmnt_tree_busy(vfs))
> > + ret--;
> > + /* just to reduce ref count taken in lookup_mnt
> > + * cannot call mntput() here
> > + */
> > + atomic_dec(&vfs->mnt_count);
> > + }
>
> Doesn't work, does it? If someone else does a mntput() just beforehand,
> __mntput() never gets run.
>
no.. it will not work. looks like we have to unlock and lock dcache_lock and
use mntput as I did earlier. But I think, it will be really nice if Jermey
can revisit is_tree_busy() code.
There can be other problems like the checking d_count for dentries under
dcache_lock(). As users can do dget() or dput() manipulating d_count without
dcache_lock().
Maneesh
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
prev parent reply other threads:[~2003-08-06 5:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 22:16 [PATCH] autofs4 doesn't expire Dick Streefland
2003-08-05 23:49 ` Andrew Morton
2003-08-06 0:03 ` Jeremy Fitzhardinge
2003-08-06 4:28 ` Maneesh Soni
2003-08-06 4:34 ` Jeremy Fitzhardinge
2003-08-06 5:00 ` Maneesh Soni
2003-08-06 5:01 ` Jeremy Fitzhardinge
2003-08-06 5:08 ` Andrew Morton
2003-08-06 5:38 ` Maneesh Soni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030806053807.GC1298@in.ibm.com \
--to=maneesh@in.ibm.com \
--cc=akpm@osdl.org \
--cc=dick.streefland@xs4all.nl \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).