* [PATCH 2.6.0-test3][BLUETOOTH] BUG fix for drivers/bluetooth/hci_usb.c
@ 2003-08-09 13:11 Vinay K Nallamothu
2003-08-09 19:04 ` Taneli Vähäkangas
0 siblings, 1 reply; 2+ messages in thread
From: Vinay K Nallamothu @ 2003-08-09 13:11 UTC (permalink / raw)
To: Maxim Krasnyansky; +Cc: LKML, trivial
Hi,
The patch below fixes two pointer reference bugs (shows up as compile
time warnings given below) which wrongly take the address of "struct
usb_interface*".
============compiler warning============================
drivers/bluetooth/hci_usb.c: In function `hci_usb_probe':
drivers/bluetooth/hci_usb.c:786: warning: assignment from incompatible
pointer type
drivers/bluetooth/hci_usb.c:810: warning: assignment from incompatible
pointer type
=========================================================================
diff -urN linux-2.6.0-test3/drivers/bluetooth/hci_usb.c linux-2.6.0-test3-nvk/drivers/bluetooth/hci_usb.c
--- linux-2.6.0-test3/drivers/bluetooth/hci_usb.c 2003-07-15 17:22:49.000000000 +0530
+++ linux-2.6.0-test3-nvk/drivers/bluetooth/hci_usb.c 2003-08-09 18:17:21.000000000 +0530
@@ -783,7 +783,7 @@
BT_DBG("udev %p ifnum %d", udev, ifnum);
- iface = &udev->actconfig->interface[0];
+ iface = udev->actconfig->interface[0];
/* Check our black list */
if (usb_match_id(intf, ignore_ids))
@@ -807,7 +807,7 @@
ifn = min_t(unsigned int, udev->actconfig->desc.bNumInterfaces, HCI_MAX_IFACE_NUM);
for (i = 0; i < ifn; i++) {
- iface = &udev->actconfig->interface[i];
+ iface = udev->actconfig->interface[i];
for (a = 0; a < iface->num_altsetting; a++) {
uif = &iface->altsetting[a];
for (e = 0; e < uif->desc.bNumEndpoints; e++) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.0-test3][BLUETOOTH] BUG fix for drivers/bluetooth/hci_usb.c
2003-08-09 13:11 [PATCH 2.6.0-test3][BLUETOOTH] BUG fix for drivers/bluetooth/hci_usb.c Vinay K Nallamothu
@ 2003-08-09 19:04 ` Taneli Vähäkangas
0 siblings, 0 replies; 2+ messages in thread
From: Taneli Vähäkangas @ 2003-08-09 19:04 UTC (permalink / raw)
To: Vinay K Nallamothu; +Cc: Maxim Krasnyansky, LKML, trivial
On Sat, Aug 09, 2003 at 06:41:59PM +0530, Vinay K Nallamothu wrote:
> Hi,
>
> The patch below fixes two pointer reference bugs (shows up as compile
> time warnings given below) which wrongly take the address of "struct
> usb_interface*".
>
> ============compiler warning============================
> drivers/bluetooth/hci_usb.c: In function `hci_usb_probe':
> drivers/bluetooth/hci_usb.c:786: warning: assignment from incompatible
> pointer type
> drivers/bluetooth/hci_usb.c:810: warning: assignment from incompatible
> pointer type
Hey, not only that, the fix also made bluetooth work for me (previously
it would just oops when loading hci-usb). Thanks a lot!
Taneli
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-08-09 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-09 13:11 [PATCH 2.6.0-test3][BLUETOOTH] BUG fix for drivers/bluetooth/hci_usb.c Vinay K Nallamothu
2003-08-09 19:04 ` Taneli Vähäkangas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).