From: Bernd Petrovitsch <bernd@firmix.at>
To: Anthony Truong <Anthony.Truong@mascorp.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: generic strncpy - off-by-one error
Date: 12 Aug 2003 23:53:58 +0200 [thread overview]
Message-ID: <1060725239.1500.22.camel@gimli.at.home> (raw)
In-Reply-To: <1060708460.12532.59.camel@dhcp22.swansea.linux.org.uk>
On Tue, 2003-08-12 at 19:14, Alan Cox wrote:
> On Maw, 2003-08-12 at 02:56, Anthony Truong wrote:
> > Thanks for pointing that out to me. However, I don't think the kernel
> > strncpy implementation is exactly the same as that of Standard C lib
>
> It is true it doesnt need to be
Nevertheless it is defined the inefficient way by the C-Standard and
lots of people actually really know this.
So IMHO (re)implementing a function called "strncpy" differently doesn't
make much sense.
> > implementation. Iwas just looking at it from the kernel code context.
The kernel is implemented in C. And the function strncpy() _is_ already
defined by C. So please use at least another name. Given the existence
of strlcpy() - http://www.courtesan.com/todd/papers/strlcpy.html- this
problem already has been solved.
> > There's a point in doing it the "kernel" way, to save precious CPU
> > cycles from being wasted otherwise.
>
> CPU cycles, got lots of those 8). If its going to do anything it might
> be to reference an extra cache line. For people who dont need padding
> 2.6 has strlcpy. Lots of drivers assume strncpy fills the entire block
ACK. To use strlcpy() is correct solution (if padding is not required).
Bernd
next prev parent reply other threads:[~2003-08-12 21:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 1:56 generic strncpy - off-by-one error Anthony Truong
2003-08-12 17:14 ` Alan Cox
2003-08-12 21:53 ` Bernd Petrovitsch [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-20 7:43 Peter Kjellerstedt
2003-08-16 21:10 Peter Kjellerstedt
2003-08-18 18:41 ` Timothy Miller
2003-08-16 20:08 Peter Kjellerstedt
2003-08-16 9:19 Peter Kjellerstedt
2003-08-16 10:04 ` Daniel Forrest
2003-08-18 16:40 ` Timothy Miller
2003-08-16 8:15 Peter Kjellerstedt
2003-08-16 8:41 ` Daniel Forrest
2003-08-18 16:17 ` Timothy Miller
2003-08-18 16:06 ` Timothy Miller
2003-08-15 9:54 Peter Kjellerstedt
2003-08-15 17:52 ` Timothy Miller
2003-08-15 9:53 Peter Kjellerstedt
2003-08-15 17:47 ` Timothy Miller
2003-08-14 9:34 Peter Kjellerstedt
2003-08-14 19:45 ` Willy Tarreau
2003-08-14 20:24 ` Timothy Miller
2003-08-13 3:09 Anthony Truong
2003-08-13 2:18 Albert Cahalan
2003-08-13 2:47 ` Erik Andersen
2003-08-13 3:38 ` Albert Cahalan
2003-08-13 3:56 ` Nick Piggin
2003-08-13 5:18 ` Willy Tarreau
2003-08-13 19:03 ` Timothy Miller
2003-08-12 14:07 Yoshinori Sato
2003-08-12 14:39 ` Willy Tarreau
2003-08-12 14:50 ` Yoshinori Sato
2003-08-12 15:03 ` Valdis.Kletnieks
2003-08-12 15:54 ` William Gallafent
2003-08-12 16:19 ` Valdis.Kletnieks
2003-08-12 16:09 ` Andreas Schwab
2003-08-12 1:28 Anthony Truong
2003-08-12 16:24 ` Bernd Petrovitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1060725239.1500.22.camel@gimli.at.home \
--to=bernd@firmix.at \
--cc=Anthony.Truong@mascorp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).