From: Daniel Forrest <forrest@lmcg.wisc.edu>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: "'Daniel Forrest'" <forrest@lmcg.wisc.edu>,
"'Timothy Miller'" <miller@techsource.com>,
"'Willy Tarreau'" <willy@w.ods.org>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: generic strncpy - off-by-one error
Date: Sat, 16 Aug 2003 05:04:15 -0500 [thread overview]
Message-ID: <20030816050415.A6986@rda07.lmcg.wisc.edu> (raw)
In-Reply-To: <D069C7355C6E314B85CF36761C40F9A42E20BC@mailse02.se.axis.com>; from peter.kjellerstedt@axis.com on Sat, Aug 16, 2003 at 11:19:30AM +0200
On Sat, Aug 16, 2003 at 11:19:30AM +0200, Peter Kjellerstedt wrote:
>
> Actually, it should be:
>
> while (count && ((long)tmp & (sizeof(long) - 1)))
>
Oops, you're right, I forgot that the count could be small.
But, now that I think of it, maybe this would be best...
char *strncpy(char *dest, const char *src, size_t count)
{
char *tmp = dest;
while (count && *src) {
*tmp++ = *src++;
count--;
}
- if (count) {
+ if (count >= sizeof(long)) {
size_t count2;
- while (count && ((long)tmp & (sizeof(long) - 1))) {
+ while ((long)tmp & (sizeof(long) - 1)) {
*tmp++ = '\0';
count--;
}
count2 = count / sizeof(long);
while (count2) {
*((long *)tmp)++ = '\0';
count2--;
}
count &= (sizeof(long) - 1);
- while (count) {
- *tmp++ = '\0';
- count--;
- }
+ }
+
+ while (count) {
+ *tmp++ = '\0';
+ count--;
}
return dest;
}
--
Dan
next prev parent reply other threads:[~2003-08-16 10:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-16 9:19 generic strncpy - off-by-one error Peter Kjellerstedt
2003-08-16 10:04 ` Daniel Forrest [this message]
2003-08-18 16:40 ` Timothy Miller
-- strict thread matches above, loose matches on Subject: below --
2003-08-20 7:43 Peter Kjellerstedt
2003-08-16 21:10 Peter Kjellerstedt
2003-08-18 18:41 ` Timothy Miller
2003-08-16 20:08 Peter Kjellerstedt
2003-08-16 8:15 Peter Kjellerstedt
2003-08-16 8:41 ` Daniel Forrest
2003-08-18 16:17 ` Timothy Miller
2003-08-18 16:06 ` Timothy Miller
2003-08-15 9:54 Peter Kjellerstedt
2003-08-15 17:52 ` Timothy Miller
2003-08-15 9:53 Peter Kjellerstedt
2003-08-15 17:47 ` Timothy Miller
2003-08-14 9:34 Peter Kjellerstedt
2003-08-14 19:45 ` Willy Tarreau
2003-08-14 20:24 ` Timothy Miller
2003-08-13 3:09 Anthony Truong
2003-08-13 2:18 Albert Cahalan
2003-08-13 2:47 ` Erik Andersen
2003-08-13 3:38 ` Albert Cahalan
2003-08-13 3:56 ` Nick Piggin
2003-08-13 5:18 ` Willy Tarreau
2003-08-13 19:03 ` Timothy Miller
2003-08-12 14:07 Yoshinori Sato
2003-08-12 14:39 ` Willy Tarreau
2003-08-12 14:50 ` Yoshinori Sato
2003-08-12 15:03 ` Valdis.Kletnieks
2003-08-12 15:54 ` William Gallafent
2003-08-12 16:19 ` Valdis.Kletnieks
2003-08-12 16:09 ` Andreas Schwab
2003-08-12 1:56 Anthony Truong
2003-08-12 17:14 ` Alan Cox
2003-08-12 21:53 ` Bernd Petrovitsch
2003-08-12 1:28 Anthony Truong
2003-08-12 16:24 ` Bernd Petrovitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030816050415.A6986@rda07.lmcg.wisc.edu \
--to=forrest@lmcg.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=miller@techsource.com \
--cc=peter.kjellerstedt@axis.com \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).