[PATCH] 2.6.0-test4: small updates for zoran driver

[PATCH] 2.6.0-test4: small updates for zoran driver

[Ronald Bultje]

Hey,

I've got 6 small patches to fix various small issues noticed by people
with the zoran driver that was accepted in 2.6.0-test3. These patches
should fix some of these issues. Most were noticed by Francois Romieu
(#1, #4-6). #2 was noticed by Linus (symbol conflict), #3 was already
announced by Gerd Knorr (v4l maitainer) some time ago, but I forgot to
actually apply the fix for that to my driver.

#1 fixes several memleaks in error cases when the setup of i2c client
drivers for video encoders/decoders fails. We forgot to free some memory
in various places.

#2 renames debug to zr_debug because debug is already defined somewhere
else.

#3 adds a release callback which frees the video_device struct. This is
needed to prevent freeing memoy before it's not in use anymore, as
described in http://lwn.net/Articles/36850/. Without this, the driver
will give a warning when loaded.

#4 adds pci_disable_device() to the card release function, we already
used pci_enable_device() in the card detection function.

#5 changes some funky coding style (a.k.a. indent artifact) to a
somewhat more conservative coding style.

#6 adds some newlines between variable declarations and function bodies.

1: http://213.197.11.65/ronald/patches/20030821_memleak_fixes.diff
2: http://213.197.11.65/ronald/patches/20030822_debug.diff
3: http://213.197.11.65/ronald/patches/20030821_vdf_release.diff
4: http://213.197.11.65/ronald/patches/20030823_disable_device.diff
5: http://213.197.11.65/ronald/patches/20030821_indenting.diff
6: http://213.197.11.65/ronald/patches/20030821_whitespace.diff

Please apply all of them.

On a related note, I'm not trying to be a pain in the ass by not
inlining patches, but Evolution doesn't seem to like me doing that, so
I'm kind of forced to do it differently. Is anyone else here using
Evolution to send in patches or is Evolution broken?

Thanks,

Ronald

-- 
Ronald Bultje <rbultje@ronald.bitfreak.net>

Re: [PATCH] 2.6.0-test4: small updates for zoran driver

[Andrew Morton]

Ronald Bultje <rbultje@ronald.bitfreak.net> wrote:
>
> On a related note, I'm not trying to be a pain in the ass by not
>  inlining patches, but Evolution doesn't seem to like me doing that, so
>  I'm kind of forced to do it differently.

You're right, it is a pain.  I need to pull each patch down, go back to
your original email, cut-n-paste the changlog, etc.  For patches-via-email
I have all that scripted, or course.  Plus nobody will bother reading the
patches.  

I would have done it anyway, but half the URLs you provided go 404.

> Is anyone else here using
>  Evolution to send in patches or is Evolution broken?

It's broken.  So is mozilla mailnews.

Attachments should be OK.  One patch per email, with a good title and the
changelog text in the email body.  Nice and easy.

Thanks.

Re: [PATCH] 2.6.0-test4: small updates for zoran driver

[Ronald Bultje]

Hey Andrew,

On Sun, 2003-08-24 at 05:29, Andrew Morton wrote:
> I would have done it anyway, but half the URLs you provided go 404.
[..]
> > Is anyone else here using
> >  Evolution to send in patches or is Evolution broken?
> 
> It's broken.  So is mozilla mailnews.
> 
> Attachments should be OK.  One patch per email, with a good title and the
> changelog text in the email body.  Nice and easy.

Ok, I'll use attachments from now on. Do you want me to re-submit the
patches?

Thanks,

Ronald

-- 
Ronald Bultje <rbultje@ronald.bitfreak.net>