* [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put
@ 2019-01-14 16:44 Julia Lawall
2019-01-14 18:13 ` Laurent Pinchart
2019-01-14 22:01 ` Kieran Bingham
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2019-01-14 16:44 UTC (permalink / raw)
To: Kieran Bingham
Cc: Laurent Pinchart, kernel-janitors, David Airlie, Daniel Vetter,
dri-devel, linux-renesas-soc, linux-kernel
Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.
Add a second of_node_put if no encoder is selected (encoder remains NULL).
The semantic match that finds the first problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
when != true e == NULL
when != of_node_put(e)
when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: Add the second of_node_put(entity);, as suggested by Kieran Bingham.
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 9c7007d..f9a90ff 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -331,6 +331,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
dev_dbg(rcdu->dev,
"connected entity %pOF is disabled, skipping\n",
entity);
+ of_node_put(entity);
return -ENODEV;
}
@@ -366,6 +367,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
dev_warn(rcdu->dev,
"no encoder found for endpoint %pOF, skipping\n",
ep->local_node);
+ of_node_put(entity);
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put
2019-01-14 16:44 [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put Julia Lawall
@ 2019-01-14 18:13 ` Laurent Pinchart
2019-01-14 22:01 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2019-01-14 18:13 UTC (permalink / raw)
To: Julia Lawall
Cc: Kieran Bingham, kernel-janitors, David Airlie, Daniel Vetter,
dri-devel, linux-renesas-soc, linux-kernel
Hi Julia,
Thank you for the patch.
On Monday, 14 January 2019 18:44:56 EET Julia Lawall wrote:
> Add an of_node_put when the result of of_graph_get_remote_port_parent is
> not available.
>
> Add a second of_node_put if no encoder is selected (encoder remains NULL).
>
> The semantic match that finds the first problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @r exists@
> local idexpression e;
> expression x;
> @@
> e = of_graph_get_remote_port_parent(...);
> ... when != x = e
> when != true e == NULL
> when != of_node_put(e)
> when != of_fwnode_handle(e)
> (
> return e;
>
> *return ...;
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> v2: Add the second of_node_put(entity);, as suggested by Kieran Bingham.
>
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 9c7007d..f9a90ff 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -331,6 +331,7 @@ static int rcar_du_encoders_init_one(struct
> rcar_du_device *rcdu, dev_dbg(rcdu->dev,
> "connected entity %pOF is disabled, skipping\n",
> entity);
> + of_node_put(entity);
> return -ENODEV;
> }
>
> @@ -366,6 +367,7 @@ static int rcar_du_encoders_init_one(struct
> rcar_du_device *rcdu, dev_warn(rcdu->dev,
> "no encoder found for endpoint %pOF, skipping\n",
> ep->local_node);
> + of_node_put(entity);
> return -ENODEV;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put
2019-01-14 16:44 [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put Julia Lawall
2019-01-14 18:13 ` Laurent Pinchart
@ 2019-01-14 22:01 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2019-01-14 22:01 UTC (permalink / raw)
To: Julia Lawall
Cc: Laurent Pinchart, kernel-janitors, David Airlie, Daniel Vetter,
dri-devel, linux-renesas-soc, linux-kernel
Hi Julia,
On 14/01/2019 16:44, Julia Lawall wrote:
> Add an of_node_put when the result of of_graph_get_remote_port_parent is
> not available.
>
> Add a second of_node_put if no encoder is selected (encoder remains NULL).
>
> The semantic match that finds the first problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @r exists@
> local idexpression e;
> expression x;
> @@
> e = of_graph_get_remote_port_parent(...);
> ... when != x = e
> when != true e == NULL
> when != of_node_put(e)
> when != of_fwnode_handle(e)
> (
> return e;
> |
> *return ...;
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thankyou for the update.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> ---
> v2: Add the second of_node_put(entity);, as suggested by Kieran Bingham.
>
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index 9c7007d..f9a90ff 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -331,6 +331,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
> dev_dbg(rcdu->dev,
> "connected entity %pOF is disabled, skipping\n",
> entity);
> + of_node_put(entity);
> return -ENODEV;
> }
>
> @@ -366,6 +367,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
> dev_warn(rcdu->dev,
> "no encoder found for endpoint %pOF, skipping\n",
> ep->local_node);
> + of_node_put(entity);
> return -ENODEV;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 22:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 16:44 [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put Julia Lawall
2019-01-14 18:13 ` Laurent Pinchart
2019-01-14 22:01 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).