* Re: [PATCH 1/2] dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings
[not found] ` <20220805091211.2791-2-jia-wei.chang@mediatek.com>
@ 2022-08-05 9:18 ` Krzysztof Kozlowski
2022-08-19 9:21 ` Jia-Wei Chang
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-05 9:18 UTC (permalink / raw)
To: jia-wei.chang, Rafael J . Wysocki, Viresh Kumar, Rob Herring,
Krzysztof Kozlowski, Matthias Brugger, Hector Yuan
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, hsinyi
On 05/08/2022 11:12, jia-wei.chang wrote:
> From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
>
> Add mt8188 cpufreq hw compatible in dt-bindings.
>
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> index 9cd42a64b13e..b56d36224612 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> @@ -16,7 +16,9 @@ description:
>
> properties:
> compatible:
> - const: mediatek,cpufreq-hw
> + enum:
> + - mediatek,cpufreq-hw
Can you add a comment mentioning for which SoCs this is? Someone added a
generic compatible covering all MediaTek cpufreq-hw (all!) and now you
say it does not cover all?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings
2022-08-05 9:18 ` [PATCH 1/2] dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings Krzysztof Kozlowski
@ 2022-08-19 9:21 ` Jia-Wei Chang
0 siblings, 0 replies; 2+ messages in thread
From: Jia-Wei Chang @ 2022-08-19 9:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rafael J . Wysocki, Viresh Kumar,
Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Hector Yuan
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Project_Global_Chrome_Upstream_Group, hsinyi
On Fri, 2022-08-05 at 11:18 +0200, Krzysztof Kozlowski wrote:
> On 05/08/2022 11:12, jia-wei.chang wrote:
> > From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> >
> > Add mt8188 cpufreq hw compatible in dt-bindings.
> >
> > Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> > ---
> > .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 4
> > +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-
> > mediatek-hw.yaml
> > b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-
> > hw.yaml
> > index 9cd42a64b13e..b56d36224612 100644
> > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-
> > hw.yaml
> > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-
> > hw.yaml
> > @@ -16,7 +16,9 @@ description:
> >
> > properties:
> > compatible:
> > - const: mediatek,cpufreq-hw
> > + enum:
> > + - mediatek,cpufreq-hw
>
> Can you add a comment mentioning for which SoCs this is? Someone
> added a
> generic compatible covering all MediaTek cpufreq-hw (all!) and now
> you
> say it does not cover all?
>
> Best regards,
> Krzysztof
Hi Krzysztof,
I realized it is possible to make MT8188 completely reuse the
compatibles "mediatek,cpufreq-hw" and platform driver as well.
This series for MT8188 mediatek-cpufreq-hw is no longer required to be
reviewed.
Thanks for your help.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-19 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220805091211.2791-1-jia-wei.chang@mediatek.com>
[not found] ` <20220805091211.2791-2-jia-wei.chang@mediatek.com>
2022-08-05 9:18 ` [PATCH 1/2] dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings Krzysztof Kozlowski
2022-08-19 9:21 ` Jia-Wei Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).