RE: [ACPI] [PATCH] 2.4/2.6 use xdsdt to print table header

RE: [ACPI] [PATCH] 2.4/2.6 use xdsdt to print table header

[Yu, Luming]

>    I'm resending this patch to get it into the main ACPI source.  This
> fixes a problem where the DSDT pointer in the FADT is NULL because it
> uses the 64bit XDSDT instead.  The current code is happy to map a NULL
> address and return success to the caller.  This can crash the 
> system or
> printout garbage headers to the console.  It's a simple 
> matter to check
> table revision and use the XDSDT in favor of the DSDT.  This has been
> living happily in both the 2.4 and 2.6 ia64 tree for some 
> time.  Please
> accept.  Thanks,

I just checked with http://lia64.bkbits.net:8080/linux-ia64-2.4 .
The patch has been merged. Please take a look at
http://lia64.bkbits.net:8080/linux-ia64-2.4/diffs/drivers/acpi/tables.c@
1.11.1.1?nav=index.html|src/.|src/drivers|src/drivers/acpi|hist/drivers/
acpi/tables.c
and
http://lia64.bkbits.net:8080/linux-ia64-2.4/diffs/drivers/acpi/tables.c@
1.11.1.2?nav=index.html|src/.|src/drivers|src/drivers/acpi|hist/drivers/
acpi/tables.c

RE: [ACPI] [PATCH] 2.4/2.6 use xdsdt to print table header

[Alex Williamson]

On Tue, 2004-01-13 at 00:38, Yu, Luming wrote:
> >    I'm resending this patch to get it into the main ACPI source.  This
> > fixes a problem where the DSDT pointer in the FADT is NULL because it
> > uses the 64bit XDSDT instead.  The current code is happy to map a NULL
> > address and return success to the caller.  This can crash the 
> > system or
> > printout garbage headers to the console.  It's a simple 
> > matter to check
> > table revision and use the XDSDT in favor of the DSDT.  This has been
> > living happily in both the 2.4 and 2.6 ia64 tree for some 
> > time.  Please
> > accept.  Thanks,
> 
> I just checked with http://lia64.bkbits.net:8080/linux-ia64-2.4 .
> The patch has been merged. Please take a look at

   Right, it's in the ia64 trees, but understandably the ia64 arch
maintainers don't want to carry this non-ia64 specific patch
indefinitely.  This is a generic ACPI issue for an system that chooses
to use the xdsdt in place of the dsdt.  It should be included in the
ACPI tree and pushed up from there.  Thanks,

	Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab

RE: [ACPI] [PATCH] 2.4/2.6 use xdsdt to print table header

[Yu, Luming]

> indefinitely.  This is a generic ACPI issue for an system that chooses
> to use the xdsdt in place of the dsdt.  It should be included in the
> ACPI tree and pushed up from there.  Thanks,
> 
All right, I'll push this to Len.