From: "Heiko Stübner" <heiko@sntech.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Xing Zheng <zhengxing@rock-chips.com>,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
keescook@google.com, leozwang@google.comi, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036
Date: Wed, 30 Dec 2015 00:32:04 +0100 [thread overview]
Message-ID: <10754282.l0GYzq0NWr@diego> (raw)
In-Reply-To: <FFCE9129-357E-4643-A350-9927A5AD5720@gmail.com>
Am Dienstag, 29. Dezember 2015, 14:59:59 schrieb Florian Fainelli:
> On December 27, 2015 11:22:20 PM PST, Xing Zheng <zhengxing@rock-chips.com>
wrote:
> >The RK3036's GRFs offset are different with RK3066/RK3188, and need to
> >set
> >mac TX/RX clock before probe emac.
> >
> >Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >---
>
> <snip>
>
> > };
> >
> > static const struct of_device_id emac_rockchip_dt_ids[] = {
> >
> >- { .compatible = "rockchip,rk3066-emac", .data =
> >&emac_rockchip_dt_data[0] },
> >- { .compatible = "rockchip,rk3188-emac", .data =
> >&emac_rockchip_dt_data[1] },
> >+ { .compatible = "rockchip,rk3036-emac", .data =
> >&emac_rockchip_dt_data[0] },
> >+ { .compatible = "rockchip,rk3066-emac", .data =
> >&emac_rockchip_dt_data[1] },
> >+ { .compatible = "rockchip,rk3188-emac", .data =
> >&emac_rockchip_dt_data[2] },
> >
> > { /* Sentinel */ }
>
> Food for thought, you might want to use an enum here to index
> emac_rockchip_dt_data which would be less error prone if you add/remove
> entries in this structure.
Or just have the structs separately and not in array-form at all, aka
rk3066_emac_dt_data, rk3036_emac_dt_data.
I don't think the original array really improves anything.
next prev parent reply other threads:[~2015-12-29 23:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 7:22 [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 1/4] net: ethernet: arc: Probe emac after set RMII clock Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 2/4] net: ethernet: arc: Keep emac compatibility for more Rockchip SoCs Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Xing Zheng
2015-12-29 22:59 ` Florian Fainelli
2015-12-29 23:32 ` Heiko Stübner [this message]
2016-01-01 12:55 ` Arnd Bergmann
2016-01-02 2:38 ` Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 4/4] ARM: dts: rockchip: " Xing Zheng
2015-12-29 20:53 ` [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform David Miller
2015-12-29 22:27 ` Heiko Stübner
2015-12-29 22:56 ` Florian Fainelli
2015-12-30 1:48 ` David Miller
2015-12-30 10:17 ` Geert Uytterhoeven
2015-12-30 15:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10754282.l0GYzq0NWr@diego \
--to=heiko@sntech.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=keescook@google.com \
--cc=leozwang@google.comi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).