From: David Miller <davem@davemloft.net>
To: heiko@sntech.de
Cc: zhengxing@rock-chips.com, linux-rockchip@lists.infradead.org,
keescook@google.com, leozwang@google.comi,
linux@arm.linux.org.uk, devicetree@vger.kernel.org,
netdev@vger.kernel.org, paul.gortmaker@windriver.com,
galak@codeaurora.org, linux-kernel@vger.kernel.org,
ijc+devicetree@hellion.org.uk, pawel.moll@arm.com,
geert@linux-m68k.org, mark.rutland@arm.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform
Date: Tue, 29 Dec 2015 20:48:47 -0500 (EST) [thread overview]
Message-ID: <20151229.204847.578920480799799256.davem@davemloft.net> (raw)
In-Reply-To: <3925713.yDzK1dvrIv@diego>
From: Heiko Stübner <heiko@sntech.de>
Date: Tue, 29 Dec 2015 23:27:55 +0100
> Hi Dave,
>
> Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller:
>> You have to submit this series properly, the same problem happend twice
>> now.
>>
>> When you submit a series you should:
>>
>> 1) Make it clear which tree you expect these changes to be applied
>> to. Here it is completely ambiguous, do you want it to go into
>> my networking tree or some other subsystem tree?
>>
>> 2) You MUST keep all parties informed about all patches for a series
>> like this. That means you cannot drop netdev from patch #4 as
>> you did both times. Doing this aggravates the situation for
>> #1 even more, because if a patch is not CC:'d to netdev it does
>> not enter patchwork. And if it doesn't go into patchwork, I'm
>> not looking at it.
>
> I guess that is some unfortunate result of git send-email combined with
> get_maintainer.pl . In general I also prefer to see the whole series, but have
> gotten such partial series from other maintainers as well in the past, so it
> seems to be depending on preferences somewhat.
>
> For the series at hand, the 4th patch is the devicetree addition, which the
> expected way is me picking it up, after you are comfortable with the code-
> related changes.
Why would it not be appropriate for a DT file change to go into my tree
if it corresponds to functionality created by the rest of the patches
in the series?
It looks better to put it all together as a unit, via one series, with
a merge commit containing your "[PATCH 0/N]" description in the commit
message.
next prev parent reply other threads:[~2015-12-30 1:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 7:22 [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 1/4] net: ethernet: arc: Probe emac after set RMII clock Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 2/4] net: ethernet: arc: Keep emac compatibility for more Rockchip SoCs Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Xing Zheng
2015-12-29 22:59 ` Florian Fainelli
2015-12-29 23:32 ` Heiko Stübner
2016-01-01 12:55 ` Arnd Bergmann
2016-01-02 2:38 ` Xing Zheng
2015-12-28 7:22 ` [RESEND PATCH v1 4/4] ARM: dts: rockchip: " Xing Zheng
2015-12-29 20:53 ` [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform David Miller
2015-12-29 22:27 ` Heiko Stübner
2015-12-29 22:56 ` Florian Fainelli
2015-12-30 1:48 ` David Miller [this message]
2015-12-30 10:17 ` Geert Uytterhoeven
2015-12-30 15:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229.204847.578920480799799256.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=keescook@google.com \
--cc=leozwang@google.comi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).