From: "Zhang,Qiang" <qiang.zhang@windriver.com>
To: paulmck@kernel.org
Cc: Joel Fernandes <joel@joelfernandes.org>,
Uladzislau Rezki <urezki@gmail.com>,
"josh@joshtriplett.org" <josh@joshtriplett.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: 回复: RCU: Question on force_qs_rnp
Date: Tue, 15 Sep 2020 13:16:39 +0800 [thread overview]
Message-ID: <1079509d-c474-42bd-44e9-18cfa948fbae@windriver.com> (raw)
In-Reply-To: <20200915034139.GK29330@paulmck-ThinkPad-P72>
On 9/15/20 11:41 AM, Paul E. McKenney wrote:
> On Tue, Sep 15, 2020 at 03:18:23AM +0000, Zhang, Qiang wrote:
>>
>>
>> ________________________________________
>> 发件人: Paul E. McKenney <paulmck@kernel.org>
>> 发送时间: 2020年9月15日 4:56
>> 收件人: Joel Fernandes
>> 抄送: Zhang, Qiang; Uladzislau Rezki; josh@joshtriplett.org; rostedt@goodmis.org; mathieu.desnoyers@efficios.com; Lai Jiangshan; rcu@vger.kernel.org; LKML
>> 主题: Re: RCU: Question on force_qs_rnp
>>
>> On Mon, Sep 14, 2020 at 03:42:08PM -0400, Joel Fernandes wrote:
>>> On Mon, Sep 14, 2020 at 07:55:18AM +0000, Zhang, Qiang wrote:
>>>> Hello Paul
>>>>
>>>> I have some questions for you .
>>>> in force_qs_rnp func , if "f(rdp)" func return true we will call rcu_report_qs_rnp func
>>>> report a quiescent state for this rnp node, and clear grpmask form rnp->qsmask.
>>>> after that , can we make a check for this rnp->qsmask, if rnp->qsmask == 0,
>>>> we will check blocked readers in this rnp node, instead of jumping directly to the next node .
>>>
>>> Could you clarify what good is this going to do? What problem are you trying to
>>> address?
>>>
>>> You could have a task that is blocked in an RCU leaf node, but the
>>> force_qs_rnp() decided to call rcu_report_qs_rnp(). This is perfectly Ok. The
>>> CPU could be dyntick-idle and a quiescent state is reported. However, the GP
>>> must not end and the rcu leaf node should still be present in its parent
>>> intermediate nodes ->qsmask. In this case, the ->qsmask == 0 does not have
>>> any relevance.
>>>
>>> Or am I missing the point of the question?
>>
>>> Hello, Qiang,
>>
>>> Another way of making Joel's point is to say that the additional check
>>> you are asking for is already being done, but by rcu_report_qs_rnp().
>>
>>> Thanx, Paul
>>
>> Hello Pual, Joel
>>
>> What I want to express is as follows :
>>
>> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
>> index 7623128d0020..beb554539f01 100644
>> --- a/kernel/rcu/tree.c
>> +++ b/kernel/rcu/tree.c
>> @@ -2622,6 +2622,11 @@ static void force_qs_rnp(int (*f)(struct rcu_data *rdp))
>> if (mask != 0) {
>> /* Idle/offline CPUs, report (releases rnp->lock). */
>> rcu_report_qs_rnp(mask, rnp, rnp->gp_seq, flags);
>> + raw_spin_lock_irqsave_rcu_node(rnp, flags);
>> + if (rnp->qsmask == 0 && rcu_preempt_blocked_readers_cgp(rnp))
>> + rcu_initiate_boost(rnp, flags);
>> + else
>> + raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
>> } else {
>> /* Nothing to do here, so just drop the lock. */
>> raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
>
> But in that case, why duplicate the code from rcu_initiate_boost()?
>
> Thanx, Paul
>
Hello Paul
When we force a qs for rnp, we first check the leaf node "rnp->qsmask"
if it is reached zero, will check if there are some blocked readers in
this leaf rnp node, if so we need to priority-boost blocked readers.
if not we will check cpu dyntick-idle and report leaf node qs, after
this leaf rnp node report qs, there is may be some blocked readers in
this node, should we also need to priority-boost blocked readers?
Thanks
Qiang
next prev parent reply other threads:[~2020-09-15 5:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:55 RCU: Question on force_qs_rnp Zhang, Qiang
2020-09-14 19:42 ` Joel Fernandes
2020-09-14 20:56 ` Paul E. McKenney
2020-09-15 3:18 ` 回复: " Zhang, Qiang
2020-09-15 3:41 ` Paul E. McKenney
2020-09-15 5:16 ` Zhang,Qiang [this message]
2020-09-15 18:06 ` Paul E. McKenney
2020-09-16 6:32 ` Zhang,Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079509d-c474-42bd-44e9-18cfa948fbae@windriver.com \
--to=qiang.zhang@windriver.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).