From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: "Zhang, Qiang" <Qiang.Zhang@windriver.com>,
Uladzislau Rezki <urezki@gmail.com>,
"josh@joshtriplett.org" <josh@joshtriplett.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: RCU: Question on force_qs_rnp
Date: Mon, 14 Sep 2020 13:56:42 -0700 [thread overview]
Message-ID: <20200914205642.GE29330@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200914194208.GA2579423@google.com>
On Mon, Sep 14, 2020 at 03:42:08PM -0400, Joel Fernandes wrote:
> On Mon, Sep 14, 2020 at 07:55:18AM +0000, Zhang, Qiang wrote:
> > Hello Paul
> >
> > I have some questions for you .
> > in force_qs_rnp func , if "f(rdp)" func return true we will call rcu_report_qs_rnp func
> > report a quiescent state for this rnp node, and clear grpmask form rnp->qsmask.
> > after that , can we make a check for this rnp->qsmask, if rnp->qsmask == 0,
> > we will check blocked readers in this rnp node, instead of jumping directly to the next node .
>
> Could you clarify what good is this going to do? What problem are you trying to
> address?
>
> You could have a task that is blocked in an RCU leaf node, but the
> force_qs_rnp() decided to call rcu_report_qs_rnp(). This is perfectly Ok. The
> CPU could be dyntick-idle and a quiescent state is reported. However, the GP
> must not end and the rcu leaf node should still be present in its parent
> intermediate nodes ->qsmask. In this case, the ->qsmask == 0 does not have
> any relevance.
>
> Or am I missing the point of the question?
Hello, Qiang,
Another way of making Joel's point is to say that the additional check
you are asking for is already being done, but by rcu_report_qs_rnp().
Thanx, Paul
next prev parent reply other threads:[~2020-09-14 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:55 RCU: Question on force_qs_rnp Zhang, Qiang
2020-09-14 19:42 ` Joel Fernandes
2020-09-14 20:56 ` Paul E. McKenney [this message]
2020-09-15 3:18 ` 回复: " Zhang, Qiang
2020-09-15 3:41 ` Paul E. McKenney
2020-09-15 5:16 ` Zhang,Qiang
2020-09-15 18:06 ` Paul E. McKenney
2020-09-16 6:32 ` Zhang,Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914205642.GE29330@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=Qiang.Zhang@windriver.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).