From: Rusty Russell <rusty@rustcorp.com.au>
To: Paul Jackson <pj@sgi.com>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
mbligh@aracnet.com, Andrew Morton <akpm@osdl.org>,
wli@holomorphy.com, haveblue@us.ibm.com, colpatch@us.ibm.com
Subject: Re: [PATCH] mask ADT: new mask.h file [2/22]
Date: Mon, 05 Apr 2004 17:42:47 +1000 [thread overview]
Message-ID: <1081150967.20543.23.camel@bach> (raw)
In-Reply-To: <20040405000528.513a4af8.pj@sgi.com>
On Mon, 2004-04-05 at 17:05, Paul Jackson wrote:
> P.S. - Perhaps you real concern here is that I'm not going far enough.
>
> Instead of just putting the cpumask_t internals on a diet
> and allowing for a nodemask_t that shares implementation,
> rather I should change both outright, to the more explicit
> style that is perhaps what you have in mind:
>
> struct cpumap { DECLARE_BITMAP(bits, NR_CPUS); };
> struct cpumask s, d1, d2;
> bitmap_or(s.bits, d1.bits, d2.bits);
>
> Nuke cpumask_t, nodemask_t and the existing cpus_or,
> nodes_or, ... and similar such 60 odd various macros
> specific to these two types.
>
> I rather like that approach. It would build nicely on
> what I've done so far. It would be a more intrusive patch,
> changing all declarations and operations on cpumasks.
Yes, this is exactly the point I was incoherently groping towards.
Throw away mask.h, and make any needed enhancements to bitmap.h (eg.
inlines which check for the case of len <= BITS_PER_LONG).
Then change cpumask_t and nodemask_t ops to inlines which just use
bitmap.h, and get rid of the
asm-generic/cpumask_optimized_for_large_smp_with_sparse_array_and_small_stack.h etc. and then finally look at how ugly it would be to change users to directly using the bitmap.h functions on cpumasks.
> If I thought it would sell, I would be most interested.
I guess I'd like to see the cost of perfection. It could just be that
the current cpumask_t headers creep me out...
Thanks!
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-04-05 7:43 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 12:12 [PATCH] mask ADT: new mask.h file [2/22] Paul Jackson
2004-03-30 0:30 ` Matthew Dobson
2004-03-30 0:27 ` Paul Jackson
2004-03-30 1:56 ` Matthew Dobson
2004-03-30 0:47 ` Paul Jackson
2004-03-30 1:53 ` Matthew Dobson
2004-03-30 2:06 ` William Lee Irwin III
2004-03-30 1:31 ` Paul Jackson
2004-03-30 1:27 ` William Lee Irwin III
2004-03-30 1:27 ` Paul Jackson
2004-03-30 6:38 ` William Lee Irwin III
2004-03-30 8:45 ` Paul Jackson
2004-03-30 10:19 ` William Lee Irwin III
2004-03-31 0:16 ` Ray Bryant
2004-03-31 0:14 ` Jesse Barnes
2004-03-30 2:07 ` William Lee Irwin III
2004-04-01 0:38 ` Matthew Dobson
2004-04-01 0:58 ` Paul Jackson
2004-04-01 1:11 ` Matthew Dobson
2004-04-01 1:18 ` Paul Jackson
2004-04-01 1:27 ` Andrew Morton
2004-04-01 1:35 ` Paul Jackson
2004-04-05 1:26 ` Rusty Russell
2004-04-05 7:05 ` Paul Jackson
2004-04-05 7:42 ` Rusty Russell [this message]
2004-04-05 8:08 ` Paul Jackson
2004-04-06 4:59 ` Rusty Russell
2004-04-06 6:06 ` Paul Jackson
2004-04-06 6:23 ` Nick Piggin
2004-04-06 6:34 ` Paul Jackson
2004-04-06 6:49 ` Nick Piggin
2004-04-06 6:59 ` Paul Jackson
2004-04-06 7:08 ` Paul Jackson
2004-04-06 7:03 ` William Lee Irwin III
2004-04-06 7:33 ` Paul Jackson
2004-04-06 6:39 ` Rusty Russell
2004-04-06 6:45 ` Paul Jackson
2004-04-06 7:24 ` Rusty Russell
2004-04-06 7:34 ` Paul Jackson
2004-04-06 10:40 ` Paul Jackson
2004-04-07 0:02 ` Rusty Russell
2004-04-07 1:49 ` Paul Jackson
2004-04-07 3:55 ` Paul Jackson
2004-04-06 6:55 ` Nick Piggin
2004-04-06 7:34 ` Paul Jackson
2004-04-06 7:02 ` Paul Jackson
2004-04-05 7:46 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1081150967.20543.23.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=pj@sgi.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).