* [PATCH] HPT374 kernel panic - regression in 2.6.8
@ 2004-08-14 11:14 Jindrich Makovicka
2004-08-14 15:16 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Jindrich Makovicka @ 2004-08-14 11:14 UTC (permalink / raw)
To: linux-kernel
Hello,
HighPoint 374 driver in 2.6.8 can cause kernel panic on boot with
non-33MHz timings because some lines from an older version have been
included in the source again. After removing the check, HPT374 works
just fine using internal PLL.
--- old/hpt366.c 2004-08-14 13:06:12.000000000 +0200
+++ new/hpt366.c 2004-08-14 12:59:25.000000000 +0200
@@ -991,11 +991,6 @@
if (pci_get_drvdata(dev))
goto init_hpt37X_done;
- if (hpt_minimum_revision(dev,8))
- {
- printk(KERN_ERR "HPT374: Only 33MHz PCI timings are supported.\n");
- return -EOPNOTSUPP;
- }
/*
* adjust PLL based upon PCI clock, enable it, and wait for
* stabilization.
Regards,
--
Jindrich Makovicka
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HPT374 kernel panic - regression in 2.6.8
2004-08-14 11:14 [PATCH] HPT374 kernel panic - regression in 2.6.8 Jindrich Makovicka
@ 2004-08-14 15:16 ` Alan Cox
2004-08-16 22:30 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2004-08-14 15:16 UTC (permalink / raw)
To: Jindrich Makovicka; +Cc: Linux Kernel Mailing List
On Sad, 2004-08-14 at 12:14, Jindrich Makovicka wrote:
> Hello,
>
> HighPoint 374 driver in 2.6.8 can cause kernel panic on boot with
> non-33MHz timings because some lines from an older version have been
> included in the source again. After removing the check, HPT374 works
> just fine using internal PLL.
The HPT374 only supports 33Mhz timings. If you are overclocking it then
its probably going to mostly work. The lines added are not "from an
older source file" but form a port forwards of long missing and
important fixes from 2.4 that have been there for a long long time.
So the first question is why does your late series HPT37x think its
running at > 33Mhz ? Are you overclocking it ?
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HPT374 kernel panic - regression in 2.6.8
2004-08-16 22:30 ` Bartlomiej Zolnierkiewicz
@ 2004-08-16 22:00 ` Alan Cox
2004-08-17 12:25 ` Marcelo Tosatti
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2004-08-16 22:00 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jindrich Makovicka, Linux Kernel Mailing List
On Llu, 2004-08-16 at 23:30, Bartlomiej Zolnierkiewicz wrote:
> http://linus.bkbits.net:8080/linux-2.5/cset@40586b50zsHhQgPLGTlje7g_f5wGTw?nav=index.html|
> src/|src/drivers|src/drivers/ide|src/drivers/ide/pci|
> related/drivers/ide/pci/hpt366.c
>
> please read bugzilla bugs mentioned in the changelong and fix this
Already did and sent out the patch. 2.4.x is missing that small change
so it might be a good one for Marcelo to merge ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HPT374 kernel panic - regression in 2.6.8
2004-08-14 15:16 ` Alan Cox
@ 2004-08-16 22:30 ` Bartlomiej Zolnierkiewicz
2004-08-16 22:00 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-08-16 22:30 UTC (permalink / raw)
To: Alan Cox; +Cc: Jindrich Makovicka, Linux Kernel Mailing List
On Saturday 14 August 2004 17:16, Alan Cox wrote:
> On Sad, 2004-08-14 at 12:14, Jindrich Makovicka wrote:
> > Hello,
> >
> > HighPoint 374 driver in 2.6.8 can cause kernel panic on boot with
> > non-33MHz timings because some lines from an older version have been
> > included in the source again. After removing the check, HPT374 works
> > just fine using internal PLL.
>
> The HPT374 only supports 33Mhz timings. If you are overclocking it then
> its probably going to mostly work. The lines added are not "from an
> older source file" but form a port forwards of long missing and
> important fixes from 2.4 that have been there for a long long time.
2.4 driver also misses some fixes...
> So the first question is why does your late series HPT37x think its
> running at > 33Mhz ? Are you overclocking it ?
http://linus.bkbits.net:8080/linux-2.5/cset@40586b50zsHhQgPLGTlje7g_f5wGTw?nav=index.html|
src/|src/drivers|src/drivers/ide|src/drivers/ide/pci|
related/drivers/ide/pci/hpt366.c
please read bugzilla bugs mentioned in the changelong and fix this
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HPT374 kernel panic - regression in 2.6.8
2004-08-16 22:00 ` Alan Cox
@ 2004-08-17 12:25 ` Marcelo Tosatti
0 siblings, 0 replies; 5+ messages in thread
From: Marcelo Tosatti @ 2004-08-17 12:25 UTC (permalink / raw)
To: Alan Cox
Cc: Bartlomiej Zolnierkiewicz, Jindrich Makovicka, Linux Kernel Mailing List
On Mon, Aug 16, 2004 at 11:00:34PM +0100, Alan Cox wrote:
> On Llu, 2004-08-16 at 23:30, Bartlomiej Zolnierkiewicz wrote:
> > http://linus.bkbits.net:8080/linux-2.5/cset@40586b50zsHhQgPLGTlje7g_f5wGTw?nav=index.html|
> > src/|src/drivers|src/drivers/ide|src/drivers/ide/pci|
> > related/drivers/ide/pci/hpt366.c
> >
> > please read bugzilla bugs mentioned in the changelong and fix this
>
> Already did and sent out the patch. 2.4.x is missing that small change
> so it might be a good one for Marcelo to merge ?
That and the triflex update (which I have around) we miss in 2.4 that I remember.
I have no changelog for the triflex fixes however - can you write up please Bart?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-08-17 13:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-14 11:14 [PATCH] HPT374 kernel panic - regression in 2.6.8 Jindrich Makovicka
2004-08-14 15:16 ` Alan Cox
2004-08-16 22:30 ` Bartlomiej Zolnierkiewicz
2004-08-16 22:00 ` Alan Cox
2004-08-17 12:25 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).