* XFS compilation warning in 2.6.9-rc1
@ 2004-08-24 12:30 Andrew Clayton
2004-08-24 12:35 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Clayton @ 2004-08-24 12:30 UTC (permalink / raw)
To: linux-kernel
Hi,
Just got the following warning when compiling a 2.6.9-rc1, this is using
gcc version:
gcc (GCC) 3.3.3 20040412 (Red Hat Linux 3.3.3-7)
from Fedora Core 2.
CC fs/xfs/xfs_bmap.o
fs/xfs/xfs_bmap.c: In function `xfs_bmap_do_search_extents':
fs/xfs/xfs_bmap.c:3434: warning: integer constant is too large for
"long" type
fs/xfs/xfs_bmap.c:3435: warning: integer constant is too large for
"long" type
CC fs/xfs/xfs_bmap_btree.o
Cheers,
Andrew Clayton
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: XFS compilation warning in 2.6.9-rc1
2004-08-24 12:30 XFS compilation warning in 2.6.9-rc1 Andrew Clayton
@ 2004-08-24 12:35 ` Christoph Hellwig
2004-08-24 13:00 ` Andrew Clayton
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-08-24 12:35 UTC (permalink / raw)
To: Andrew Clayton; +Cc: linux-kernel
On Tue, Aug 24, 2004 at 01:30:16PM +0100, Andrew Clayton wrote:
> CC fs/xfs/xfs_bmap.o
> fs/xfs/xfs_bmap.c: In function `xfs_bmap_do_search_extents':
> fs/xfs/xfs_bmap.c:3434: warning: integer constant is too large for
> "long" type
> fs/xfs/xfs_bmap.c:3435: warning: integer constant is too large for
> "long" type
> CC fs/xfs/xfs_bmap_btree.o
--- 1.26/fs/xfs/xfs_bmap.c 2004-08-19 05:36:06 +02:00
+++ edited/fs/xfs/xfs_bmap.c 2004-08-24 14:35:40 +02:00
@@ -3431,15 +3431,16 @@
* uninitialized br_startblock field.
*/
- got.br_startoff = 0xffa5a5a5a5a5a5a5;
- got.br_blockcount = 0xa55a5a5a5a5a5a5a;
+ got.br_startoff = 0xffa5a5a5a5a5a5a5LL;
+ got.br_blockcount = 0xa55a5a5a5a5a5a5aLL;
got.br_state = XFS_EXT_INVALID;
- #if XFS_BIG_BLKNOS
- got.br_startblock = 0xffffa5a5a5a5a5a5;
- #else
- got.br_startblock = 0xffffa5a5;
- #endif
+#if XFS_BIG_BLKNOS
+ got.br_startblock = 0xffffa5a5a5a5a5a5LL;
+#else
+ got.br_startblock = 0xffffa5a5;
+#endif
+
if (lastx != NULLEXTNUM && lastx < nextents)
ep = base + lastx;
else
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: XFS compilation warning in 2.6.9-rc1
2004-08-24 12:35 ` Christoph Hellwig
@ 2004-08-24 13:00 ` Andrew Clayton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Clayton @ 2004-08-24 13:00 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel
On Tue, 2004-08-24 at 13:35, Christoph Hellwig wrote:
> --- 1.26/fs/xfs/xfs_bmap.c 2004-08-19 05:36:06 +02:00
> +++ edited/fs/xfs/xfs_bmap.c 2004-08-24 14:35:40 +02:00
> @@ -3431,15 +3431,16 @@
> * uninitialized br_startblock field.
> */
>
> - got.br_startoff = 0xffa5a5a5a5a5a5a5;
> - got.br_blockcount = 0xa55a5a5a5a5a5a5a;
> + got.br_startoff = 0xffa5a5a5a5a5a5a5LL;
> + got.br_blockcount = 0xa55a5a5a5a5a5a5aLL;
> got.br_state = XFS_EXT_INVALID;
>
> - #if XFS_BIG_BLKNOS
> - got.br_startblock = 0xffffa5a5a5a5a5a5;
> - #else
> - got.br_startblock = 0xffffa5a5;
> - #endif
> +#if XFS_BIG_BLKNOS
> + got.br_startblock = 0xffffa5a5a5a5a5a5LL;
> +#else
> + got.br_startblock = 0xffffa5a5;
> +#endif
> +
> if (lastx != NULLEXTNUM && lastx < nextents)
> ep = base + lastx;
> else
>
Yep, that sorted it.
Cheers,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-08-24 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-24 12:30 XFS compilation warning in 2.6.9-rc1 Andrew Clayton
2004-08-24 12:35 ` Christoph Hellwig
2004-08-24 13:00 ` Andrew Clayton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).