* [2.6 patch] net/typhoon.c: remove an unused function
@ 2004-10-28 23:06 Adrian Bunk
2004-10-29 0:08 ` David Dillow
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-10-28 23:06 UTC (permalink / raw)
To: David Dillow; +Cc: jgarzik, linux-net, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The patch below removes an unused function from drivers/net/typhoon.c
diffstat output:
drivers/net/typhoon.c | 8 --------
1 files changed, 8 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
- --- linux-2.6.10-rc1-mm1-full/drivers/net/typhoon.c.old 2004-10-28 23:21:30.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/net/typhoon.c 2004-10-28 23:21:44.000000000 +0200
@@ -372,14 +372,6 @@
typhoon_inc_index(index, count, TXLO_ENTRIES);
}
- -static inline void
- -typhoon_inc_rx_index(u32 *index, const int count)
- -{
- - /* sizeof(struct rx_desc) != sizeof(struct cmd_desc) */
- - *index += count * sizeof(struct rx_desc);
- - *index %= RX_ENTRIES * sizeof(struct rx_desc);
- -}
- -
static int
typhoon_reset(void __iomem *ioaddr, int wait_type)
{
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBgXt1mfzqmE8StAARAkWAAJ0dshTZ/dXqh+UdamvhZCzGA6cqvQCggWQf
JtBs+VjssQpn02lnVV9MhmA=
=6yW2
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] net/typhoon.c: remove an unused function
2004-10-28 23:06 [2.6 patch] net/typhoon.c: remove an unused function Adrian Bunk
@ 2004-10-29 0:08 ` David Dillow
0 siblings, 0 replies; 2+ messages in thread
From: David Dillow @ 2004-10-29 0:08 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Jeff Garzik, linux-net, linux-kernel
On Fri, 2004-10-29 at 01:06 +0200, Adrian Bunk wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> The patch below removes an unused function from drivers/net/typhoon.c
NAK -- I'd prefer to make it be used, which was the reason it was there
in the first place... not sure why it wasn't...
===== drivers/net/typhoon.c 1.25 vs edited =====
--- 1.25/drivers/net/typhoon.c 2004-10-21 18:42:58 -04:00
+++ edited/drivers/net/typhoon.c 2004-10-28 20:06:45 -04:00
@@ -1687,8 +1687,7 @@
skb = rxb->skb;
dma_addr = rxb->dma_addr;
- rxaddr += sizeof(struct rx_desc);
- rxaddr %= RX_ENTRIES * sizeof(struct rx_desc);
+ typhoon_inc_rx_index(&rxaddr, 1);
if(rx->flags & TYPHOON_RX_ERROR) {
typhoon_recycle_rx_skb(tp, idx);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-29 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-28 23:06 [2.6 patch] net/typhoon.c: remove an unused function Adrian Bunk
2004-10-29 0:08 ` David Dillow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).