From: zhangfei <zhangfei.gao@linaro.org>
To: Rob Herring <robh@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Guodong Xu <guodong.xu@linaro.org>, Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Chen Feng <puck.chen@hisilicon.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660
Date: Wed, 24 May 2017 10:34:09 +0800 [thread overview]
Message-ID: <10a19a02-21ac-364e-ab5c-de8aa16c3858@linaro.org> (raw)
In-Reply-To: <CAL_JsqJUH-TOufw=dtpgDww_VEvyTW_LZuSQqRSU-cYbAqfJ6A@mail.gmail.com>
Hi, Jarkko
Would you mind give some suggestion?
On 2017年05月23日 20:48, Rob Herring wrote:
>
>>>> + compatible = "snps,designware-i2c";
>>> These should have an SoC specific compatible.
>> We directly use drivers/i2c/busses/i2c-designware-platdrv.c,
>> do we still an soc specific compatible?
> It's fine if the driver uses the snps compatible, but the dts should
> still have an SoC specific one.
>
>> Checked arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi, and other examples,
>>
>> compatible = "snps,designware-i2c" is used.
> That was a mistake in the other platforms. We shouldn't continue repeating it.
>
> Rob
Rob suggest add something like "hisilicon,hi3660-dw-i2c" as well.
"The problem is dw-i2c does not give any clue as to what the
configuration or version of the IP is.
Is that fully discoverable with version/capability registers? If not
then you need a specific compatible.
Generally when we have not required them, it ends up being a problem
later on."
While Documentation/devicetree/bindings/i2c/i2c-designware.txt
compatible : should be "snps,designware-i2c"
Besides, on Hikey960,
[ 3.822353] dw_readl(dev, DW_IC_COMP_VERSION)=0x3132302a
[ 3.827763] dw_readl(dev, DW_IC_COMP_TYPE)=0x44570140
Are these two registers enough to distinguish version etc?
Thanks
next prev parent reply other threads:[~2017-05-24 2:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 8:37 [PATCH 00/12] arm64: dts: hi3660: add device nodes Guodong Xu
2017-05-17 8:37 ` [PATCH 01/12] dt-bindings: arm: hisilicon: add bindings for HiKey960 board Guodong Xu
2017-05-23 0:35 ` Rob Herring
2017-05-17 8:37 ` [PATCH 02/12] arm64: dts: hisilicon: update compatible string for hikey960 Guodong Xu
2017-05-23 0:36 ` Rob Herring
2017-05-17 8:37 ` [PATCH 03/12] arm64: dts: hikey960: pinctrl: add more pinmux and pinconfig Guodong Xu
2017-05-23 0:49 ` Rob Herring
2017-05-17 8:37 ` [PATCH 04/12] arm64: dts: hi3660: add resources for clock and reset Guodong Xu
2017-05-23 0:49 ` Rob Herring
2017-05-17 8:37 ` [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Guodong Xu
2017-05-23 0:39 ` Rob Herring
2017-05-23 5:55 ` zhangfei
2017-05-23 6:36 ` zhangfei
2017-05-23 12:44 ` Rob Herring
2017-05-23 12:48 ` Rob Herring
2017-05-24 2:34 ` zhangfei [this message]
2017-05-24 8:31 ` Jarkko Nikula
2017-05-17 8:37 ` [PATCH 06/12] arm64: dts: hi3660: add gpio dtsi file for Hisilicon Hi3660 SOC Guodong Xu
2017-05-23 0:41 ` Rob Herring
2017-05-23 11:20 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 07/12] arm64: dts: hi3660: Add uarts nodes Guodong Xu
2017-05-23 0:44 ` Rob Herring
2017-05-23 9:23 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 08/12] arm64: dts: hikey960: add WL1837 Bluetooth device node Guodong Xu
2017-05-23 0:45 ` Rob Herring
2017-05-23 8:15 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 09/12] arm64: dts: hi3660: Add pl031 rtc node Guodong Xu
2017-05-23 0:45 ` Rob Herring
2017-05-17 8:37 ` [PATCH 10/12] arm64: dts: hi3660: add spi device nodes Guodong Xu
2017-05-23 0:46 ` Rob Herring
2017-05-23 11:39 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 11/12] arm64: dts: hi3660: add power key dts node Guodong Xu
2017-05-23 0:47 ` Rob Herring
2017-05-17 8:37 ` [PATCH 12/12] arm64: dts: hikey960: add LED nodes Guodong Xu
2017-05-23 0:48 ` Rob Herring
2017-05-23 12:07 ` Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10a19a02-21ac-364e-ab5c-de8aa16c3858@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=robh@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
--cc=xuejiancheng@hisilicon.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).