From: Rob Herring <robh@kernel.org>
To: zhangfei <zhangfei.gao@linaro.org>
Cc: Guodong Xu <guodong.xu@linaro.org>, Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Chen Feng <puck.chen@hisilicon.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660
Date: Tue, 23 May 2017 07:44:35 -0500 [thread overview]
Message-ID: <CAL_JsqK5m1oAvAntaJt4CWTCR+j09xunf-QacMTQJWfO3_jxvA@mail.gmail.com> (raw)
In-Reply-To: <c7f16d66-f884-b230-4b44-29d603af12ab@linaro.org>
On Tue, May 23, 2017 at 1:36 AM, zhangfei <zhangfei.gao@linaro.org> wrote:
>
>
> On 2017年05月23日 13:55, zhangfei wrote:
>>
>> Hi, Rob
>>
>>
>> Thanks for the review.
>>
>> On 2017年05月23日 08:39, Rob Herring wrote:
>>>
>>> On Wed, May 17, 2017 at 04:37:38PM +0800, Guodong Xu wrote:
>>>>
>>>> From: Zhangfei Gao <zhangfei.gao@linaro.org>
>>>>
>>>> Add I2C nodes for Hi3660-hikey960.
>>>>
>>>> On HiKey960,
>>>> I2C0, I2C7 is connected to Low Speed Expansion Connector.
>>>> I2C1 is connected to ADV7535.
>>>> I2C3 is connected to USB5734.
>>>>
>>>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>>>> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
>>>> ---
>>>> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 18 ++++++++
>>>> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 56
>>>> +++++++++++++++++++++++
>>>> 2 files changed, 74 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>>> b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>>> index 64875a5..f685b1e 100644
>>>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>>>> @@ -29,6 +29,24 @@
>>>> };
>>>> };
>>>> +&i2c0 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&i2c1 {
>>>> + status = "okay";
>>>> +
>>>> + adv7533: adv7533@39 {
>>>> + status = "ok";
>>>> + compatible = "adi,adv7533";
>>>> + reg = <0x39>;
>>>> + };
>>>> +};
>>>> +
>>>> +&i2c7 {
>>>> + status = "okay";
>>>> +};
>>>
>>> labels for the LS connector?
>
>
> Do you mean arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>
> i2c@78ba000 {
> /* On Low speed expansion */
> label = "LS-I2C1";
> status = "okay";
> };
>
> spi@78b7000 {
> /* On High speed expansion */
> label = "HS-SPI1";
> status = "okay";
> };
Yes. And the names need to align across boards to be useful.
Rob
next prev parent reply other threads:[~2017-05-23 12:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 8:37 [PATCH 00/12] arm64: dts: hi3660: add device nodes Guodong Xu
2017-05-17 8:37 ` [PATCH 01/12] dt-bindings: arm: hisilicon: add bindings for HiKey960 board Guodong Xu
2017-05-23 0:35 ` Rob Herring
2017-05-17 8:37 ` [PATCH 02/12] arm64: dts: hisilicon: update compatible string for hikey960 Guodong Xu
2017-05-23 0:36 ` Rob Herring
2017-05-17 8:37 ` [PATCH 03/12] arm64: dts: hikey960: pinctrl: add more pinmux and pinconfig Guodong Xu
2017-05-23 0:49 ` Rob Herring
2017-05-17 8:37 ` [PATCH 04/12] arm64: dts: hi3660: add resources for clock and reset Guodong Xu
2017-05-23 0:49 ` Rob Herring
2017-05-17 8:37 ` [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660 Guodong Xu
2017-05-23 0:39 ` Rob Herring
2017-05-23 5:55 ` zhangfei
2017-05-23 6:36 ` zhangfei
2017-05-23 12:44 ` Rob Herring [this message]
2017-05-23 12:48 ` Rob Herring
2017-05-24 2:34 ` zhangfei
2017-05-24 8:31 ` Jarkko Nikula
2017-05-17 8:37 ` [PATCH 06/12] arm64: dts: hi3660: add gpio dtsi file for Hisilicon Hi3660 SOC Guodong Xu
2017-05-23 0:41 ` Rob Herring
2017-05-23 11:20 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 07/12] arm64: dts: hi3660: Add uarts nodes Guodong Xu
2017-05-23 0:44 ` Rob Herring
2017-05-23 9:23 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 08/12] arm64: dts: hikey960: add WL1837 Bluetooth device node Guodong Xu
2017-05-23 0:45 ` Rob Herring
2017-05-23 8:15 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 09/12] arm64: dts: hi3660: Add pl031 rtc node Guodong Xu
2017-05-23 0:45 ` Rob Herring
2017-05-17 8:37 ` [PATCH 10/12] arm64: dts: hi3660: add spi device nodes Guodong Xu
2017-05-23 0:46 ` Rob Herring
2017-05-23 11:39 ` Guodong Xu
2017-05-17 8:37 ` [PATCH 11/12] arm64: dts: hi3660: add power key dts node Guodong Xu
2017-05-23 0:47 ` Rob Herring
2017-05-17 8:37 ` [PATCH 12/12] arm64: dts: hikey960: add LED nodes Guodong Xu
2017-05-23 0:48 ` Rob Herring
2017-05-23 12:07 ` Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqK5m1oAvAntaJt4CWTCR+j09xunf-QacMTQJWfO3_jxvA@mail.gmail.com \
--to=robh@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
--cc=xuejiancheng@hisilicon.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).