* [PATCH] parisc: move from strlcpy with unused retval to strscpy
@ 2022-08-18 21:00 Wolfram Sang
2022-08-19 19:26 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2022-08-18 21:00 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, James E.J. Bottomley, Helge Deller, linux-parisc
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.
Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/parisc/led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index 1e4a5663d011..d4be9d2ee74d 100644
--- a/drivers/parisc/led.c
+++ b/drivers/parisc/led.c
@@ -646,7 +646,7 @@ int lcd_print( const char *str )
cancel_delayed_work_sync(&led_task);
/* copy display string to buffer for procfs */
- strlcpy(lcd_text, str, sizeof(lcd_text));
+ strscpy(lcd_text, str, sizeof(lcd_text));
/* Set LCD Cursor to 1st character */
gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] parisc: move from strlcpy with unused retval to strscpy
2022-08-18 21:00 [PATCH] parisc: move from strlcpy with unused retval to strscpy Wolfram Sang
@ 2022-08-19 19:26 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-08-19 19:26 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel; +Cc: James E.J. Bottomley, linux-parisc
On 8/18/22 23:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
applied to parisc git tree.
Thanks!
Helge
> ---
> drivers/parisc/led.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
> index 1e4a5663d011..d4be9d2ee74d 100644
> --- a/drivers/parisc/led.c
> +++ b/drivers/parisc/led.c
> @@ -646,7 +646,7 @@ int lcd_print( const char *str )
> cancel_delayed_work_sync(&led_task);
>
> /* copy display string to buffer for procfs */
> - strlcpy(lcd_text, str, sizeof(lcd_text));
> + strscpy(lcd_text, str, sizeof(lcd_text));
>
> /* Set LCD Cursor to 1st character */
> gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-19 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18 21:00 [PATCH] parisc: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-19 19:26 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).