* [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
@ 2019-10-22 8:11 Yunfeng Ye
2019-10-31 7:01 ` Yunfeng Ye
2019-11-01 6:06 ` Herbert Xu
0 siblings, 2 replies; 5+ messages in thread
From: Yunfeng Ye @ 2019-10-22 8:11 UTC (permalink / raw)
To: Herbert Xu, davem, catalin.marinas, will, ard.biesheuvel,
linux-crypto, linux-arm-kernel, linux-kernel, hushiyuan,
linfeilong
A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"
Fix this by adding return value of skcipher_walk_done().
Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
v2 -> v3:
- add "Acked-by:"
v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()
arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..e3e27349a9fe 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
goto xts_tail;
kernel_neon_end();
- skcipher_walk_done(&walk, nbytes);
+ err = skcipher_walk_done(&walk, nbytes);
}
if (err || likely(!tail))
--
2.7.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
2019-10-22 8:11 [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() Yunfeng Ye
@ 2019-10-31 7:01 ` Yunfeng Ye
2019-10-31 8:13 ` Ard Biesheuvel
2019-11-01 6:06 ` Herbert Xu
1 sibling, 1 reply; 5+ messages in thread
From: Yunfeng Ye @ 2019-10-31 7:01 UTC (permalink / raw)
To: Herbert Xu, davem, catalin.marinas, will, ard.biesheuvel,
linux-crypto, linux-arm-kernel, linux-kernel, hushiyuan,
linfeilong
A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"
Fix this by adding return value of skcipher_walk_done().
Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
v2 -> v3:
- add "Acked-by:"
v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()
arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..e3e27349a9fe 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
goto xts_tail;
kernel_neon_end();
- skcipher_walk_done(&walk, nbytes);
+ err = skcipher_walk_done(&walk, nbytes);
}
if (err || likely(!tail))
--
2.7.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
2019-10-31 7:01 ` Yunfeng Ye
@ 2019-10-31 8:13 ` Ard Biesheuvel
2019-10-31 8:15 ` Yunfeng Ye
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2019-10-31 8:13 UTC (permalink / raw)
To: Yunfeng Ye
Cc: Herbert Xu, David S. Miller, Catalin Marinas, Will Deacon,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
linux-arm-kernel, Linux Kernel Mailing List, hushiyuan,
linfeilong
On Thu, 31 Oct 2019 at 08:02, Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>
> A warning is found by the static code analysis tool:
> "Identical condition 'err', second condition is always false"
>
> Fix this by adding return value of skcipher_walk_done().
>
> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Please don't send the exact same patch twice, and when you feel the
need to do so, just ask instead whether your patch was received or
not.
I'm sure Herbert will pick it up shortly.
> ---
> v2 -> v3:
> - add "Acked-by:"
>
> v1 -> v2:
> - update the subject and comment
> - add return value of skcipher_walk_done()
>
> arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
> index ea873b8904c4..e3e27349a9fe 100644
> --- a/arch/arm64/crypto/aes-neonbs-glue.c
> +++ b/arch/arm64/crypto/aes-neonbs-glue.c
> @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
> goto xts_tail;
>
> kernel_neon_end();
> - skcipher_walk_done(&walk, nbytes);
> + err = skcipher_walk_done(&walk, nbytes);
> }
>
> if (err || likely(!tail))
> --
> 2.7.4.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
2019-10-31 8:13 ` Ard Biesheuvel
@ 2019-10-31 8:15 ` Yunfeng Ye
0 siblings, 0 replies; 5+ messages in thread
From: Yunfeng Ye @ 2019-10-31 8:15 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Herbert Xu, David S. Miller, Catalin Marinas, Will Deacon,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
linux-arm-kernel, Linux Kernel Mailing List, hushiyuan,
linfeilong
On 2019/10/31 16:13, Ard Biesheuvel wrote:
> On Thu, 31 Oct 2019 at 08:02, Yunfeng Ye <yeyunfeng@huawei.com> wrote:
>>
>> A warning is found by the static code analysis tool:
>> "Identical condition 'err', second condition is always false"
>>
>> Fix this by adding return value of skcipher_walk_done().
>>
>> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
>> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
>> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Please don't send the exact same patch twice, and when you feel the
> need to do so, just ask instead whether your patch was received or
> not.
>
ok, thanks.
> I'm sure Herbert will pick it up shortly.
>
>> ---
>> v2 -> v3:
>> - add "Acked-by:"
>>
>> v1 -> v2:
>> - update the subject and comment
>> - add return value of skcipher_walk_done()
>>
>> arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
>> index ea873b8904c4..e3e27349a9fe 100644
>> --- a/arch/arm64/crypto/aes-neonbs-glue.c
>> +++ b/arch/arm64/crypto/aes-neonbs-glue.c
>> @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
>> goto xts_tail;
>>
>> kernel_neon_end();
>> - skcipher_walk_done(&walk, nbytes);
>> + err = skcipher_walk_done(&walk, nbytes);
>> }
>>
>> if (err || likely(!tail))
>> --
>> 2.7.4.3
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
2019-10-22 8:11 [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() Yunfeng Ye
2019-10-31 7:01 ` Yunfeng Ye
@ 2019-11-01 6:06 ` Herbert Xu
1 sibling, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2019-11-01 6:06 UTC (permalink / raw)
To: Yunfeng Ye
Cc: davem, catalin.marinas, will, ard.biesheuvel, linux-crypto,
linux-arm-kernel, linux-kernel, hushiyuan, linfeilong
On Tue, Oct 22, 2019 at 04:11:18PM +0800, Yunfeng Ye wrote:
> A warning is found by the static code analysis tool:
> "Identical condition 'err', second condition is always false"
>
> Fix this by adding return value of skcipher_walk_done().
>
> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> v2 -> v3:
> - add "Acked-by:"
>
> v1 -> v2:
> - update the subject and comment
> - add return value of skcipher_walk_done()
>
> arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-01 6:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 8:11 [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt() Yunfeng Ye
2019-10-31 7:01 ` Yunfeng Ye
2019-10-31 8:13 ` Ard Biesheuvel
2019-10-31 8:15 ` Yunfeng Ye
2019-11-01 6:06 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).