* [PATCH] cciss: Off-by-one error causing oops in CCISS_GETLUNIFO ioctl
@ 2004-11-24 18:27 Andrew Patterson
0 siblings, 0 replies; only message in thread
From: Andrew Patterson @ 2004-11-24 18:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Mike Miller
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
This patch fixes an an "off-by-one" error found in the CCISS_GETLUNIFO
ioctl in the cciss driver. It is cycling through the part table of the
gendisk structure which is a zero-based array, not a one-based array.
This often causes an oops when referencing the out-of-bounds element.
Signed-off by: Andrew Patterson <andrew.patterson@hp.com>
---
--- linux-2.6.9/drivers/block/cciss.c.orig 2004-11-24 10:22:30.000000000 -0700
+++ linux-2.6.9/drivers/block/cciss.c 2004-11-24 10:27:38.000000000 -0700
@@ -799,7 +799,7 @@
luninfo.num_opens = drv->usage_count;
luninfo.num_parts = 0;
/* count partitions 1 to 15 with sizes > 0 */
- for(i=1; i <MAX_PART; i++) {
+ for(i=0; i <MAX_PART-1; i++) {
if (!disk->part[i])
continue;
if (disk->part[i]->nr_sects != 0)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-11-24 19:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-24 18:27 [PATCH] cciss: Off-by-one error causing oops in CCISS_GETLUNIFO ioctl Andrew Patterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).