From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Gaisler <jiri@gaisler.com>
Cc: sparclinux@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
wli@holomorphy.com
Subject: Re: [7/7] LEON SPARC V8 processor support for linux-2.6.10
Date: Wed, 05 Jan 2005 00:01:22 +0000 [thread overview]
Message-ID: <1104877702.17166.53.camel@localhost.localdomain> (raw)
In-Reply-To: <41DAE8CC.3010904@gaisler.com>
On Maw, 2005-01-04 at 19:04, Jiri Gaisler wrote:
> + if (tty->flip.count >= TTY_FLIPBUF_SIZE) {
> + tty->flip.work.func((void *)tty);
> + if (tty->flip.count >= TTY_FLIPBUF_SIZE) {
> + printk(KERN_WARNING "TTY_DONT_FLIP set\n");
> + return;
> + }
This code is broken. Please copy the fixes from the other
drivers/serial/*.c files as you've copied a bug from the reference code.
There are some other small cleanups in the base code that are worth
adding too in particular removing direct (ab)use of tty->flip. because
that will be changing some time in the future (when I finish debugging
the tty layer mess)
next prev parent reply other threads:[~2005-01-05 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 19:04 [7/7] LEON SPARC V8 processor support for linux-2.6.10 Jiri Gaisler
2005-01-04 19:22 ` Roland Dreier
2005-01-05 0:01 ` Alan Cox [this message]
2005-01-05 15:19 ` Jiri Gaisler
2005-01-06 12:41 ` Alan Cox
2005-01-09 9:36 ` Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104877702.17166.53.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jiri@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).