From: "J.A. Magallon" <jamagallon@able.es>
To: linux-kernel@vger.kernel.org
Subject: Re: [patch 3/3] spinlock fix #3: type-checking spinlock primitives, x86
Date: Thu, 20 Jan 2005 22:51:42 +0000 [thread overview]
Message-ID: <1106261502l.7080l.0l@werewolf.able.es> (raw)
In-Reply-To: <20050120120905.GA3493@elte.hu> (from mingo@elte.hu on Thu Jan 20 13:09:05 2005)
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On 2005.01.20, Ingo Molnar wrote:
>
> this patch would have caught the bug in -BK-curr (that patch #1 fixes),
> via a compiler warning. Test-built/booted on x86.
>
> Ingo
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
> --- linux/include/asm-i386/spinlock.h.orig
> +++ linux/include/asm-i386/spinlock.h
> @@ -36,7 +36,10 @@ typedef struct {
>
> #define SPIN_LOCK_UNLOCKED (spinlock_t) { 1 SPINLOCK_MAGIC_INIT }
>
> -#define spin_lock_init(x) do { *(x) = SPIN_LOCK_UNLOCKED; } while(0)
> +static inline void spin_lock_init(spinlock_t *lock)
Will have any real effect if you add things like:
+static inline void spin_lock_init(spinlock_t *lock) __attribute__((__pure__));
??
TIA
--
J.A. Magallon <jamagallon()able!es> \ Software is like sex:
werewolf!able!es \ It's better when it's free
Mandrakelinux release 10.2 (Cooker) for i586
Linux 2.6.10-jam4 (gcc 3.4.3 (Mandrakelinux 10.2 3.4.3-3mdk)) #2
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-01-20 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 11:43 [patch 1/3] spinlock fix #1 Ingo Molnar
2005-01-20 11:59 ` [patch 2/3] spinlock fix #2: generalize [spin|rw]lock yielding Ingo Molnar
2005-01-20 12:09 ` [patch 3/3] spinlock fix #3: type-checking spinlock primitives, x86 Ingo Molnar
2005-01-20 12:18 ` [patch] stricter type-checking rwlock " Ingo Molnar
2005-01-20 12:22 ` [patch] minor spinlock cleanups Ingo Molnar
2005-01-20 22:51 ` J.A. Magallon [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-19 9:18 Horrible regression with -CURRENT from "Don't busy-lock-loop in preemptable spinlocks" patch Peter Chubb
2005-01-19 9:20 ` Ingo Molnar
2005-01-19 21:43 ` Paul Mackerras
2005-01-20 2:34 ` [PATCH RFC] 'spinlock/rwlock fixes' V3 [1/1] Chris Wedgwood
2005-01-20 3:01 ` Andrew Morton
2005-01-20 3:18 ` Chris Wedgwood
2005-01-20 8:59 ` Peter Chubb
2005-01-20 15:51 ` Linus Torvalds
2005-01-20 16:08 ` [patch 1/3] spinlock fix #1, *_can_lock() primitives Ingo Molnar
2005-01-20 16:11 ` [patch 2/3] spinlock fix #2: generalize [spin|rw]lock yielding Ingo Molnar
2005-01-20 16:12 ` [patch 3/3] spinlock fix #3: type-checking spinlock primitives, x86 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106261502l.7080l.0l@werewolf.able.es \
--to=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).