* [2.6 patch] drivers/char/moxa.c: #if 0 an unused function
@ 2005-01-23 10:17 Adrian Bunk
2005-01-24 13:09 ` Josh Boyer
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-01-23 10:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
This patch #if 0's an unused global function.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 6 Dec 2004
--- linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c.old 2004-12-06 01:30:18.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c 2004-12-06 01:30:39.000000000 +0100
@@ -3090,6 +3090,7 @@
return (0);
}
+#if 0
long MoxaPortGetCurBaud(int port)
{
@@ -3097,6 +3098,7 @@
return (0);
return (moxaCurBaud[port]);
}
+#endif /* 0 */
static void MoxaSetFifo(int port, int enable)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/char/moxa.c: #if 0 an unused function
2005-01-23 10:17 [2.6 patch] drivers/char/moxa.c: #if 0 an unused function Adrian Bunk
@ 2005-01-24 13:09 ` Josh Boyer
0 siblings, 0 replies; 3+ messages in thread
From: Josh Boyer @ 2005-01-24 13:09 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Sun, 2005-01-23 at 04:17, Adrian Bunk wrote:
> This patch #if 0's an unused global function.
Ugh, why? Why not just remove it if it's unused?
josh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/char/moxa.c: #if 0 an unused function
2004-12-05 20:14 ` Tomasz Kłoczko
@ 2004-12-06 0:41 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2004-12-06 0:41 UTC (permalink / raw)
To: Tomasz K?oczko; +Cc: linux-kernel
On Sun, Dec 05, 2004 at 09:14:08PM +0100, Tomasz K?oczko wrote:
>...
> >- * 5. MoxaPortGetCurBaud(int port);
> >*
> > * 6. MoxaPortSetBaud(int port, long baud);
> > *
> > * 7. MoxaPortSetMode(int port, int databit, int stopbit, int parity);
> > *
> > * 8. MoxaPortSetTermio(int port, unsigned char *termio);
> > *
> [..]
>
> Prabaly it will be good renumber this or make unnumbered (and all other
> comments with "Function <num>:" :)
Perhaps the following patch is the best solution:
diffstat output:
drivers/char/moxa.c | 2 ++
1 files changed, 2 insertions(+)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c.old 2004-12-06 01:30:18.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/drivers/char/moxa.c 2004-12-06 01:30:39.000000000 +0100
@@ -3090,6 +3090,7 @@
return (0);
}
+#if 0
long MoxaPortGetCurBaud(int port)
{
@@ -3097,6 +3098,7 @@
return (0);
return (moxaCurBaud[port]);
}
+#endif /* 0 */
static void MoxaSetFifo(int port, int enable)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-24 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-23 10:17 [2.6 patch] drivers/char/moxa.c: #if 0 an unused function Adrian Bunk
2005-01-24 13:09 ` Josh Boyer
-- strict thread matches above, loose matches on Subject: below --
2004-12-05 17:02 [2.6 patch] drivers/char/moxa.c: remove " Adrian Bunk
2004-12-05 20:14 ` Tomasz Kłoczko
2004-12-06 0:41 ` [2.6 patch] drivers/char/moxa.c: #if 0 " Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).