* [PATCH] restrict inter_module_* to its last users
@ 2005-04-08 17:08 Jörn Engel
2005-04-08 17:24 ` Arjan van de Ven
2005-04-08 17:48 ` Andrew Morton
0 siblings, 2 replies; 7+ messages in thread
From: Jörn Engel @ 2005-04-08 17:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mtd
Derived from a patch Arjan sent around.
Jörn
--
The cheapest, fastest and most reliable components of a computer
system are those that aren't there.
-- Gordon Bell, DEC labratories
Next step for inter_module removal. This patch makes the code
conditional on its last users and shrinks the kernel binary for the
huge majority of people.
Signed-off-by: Jörn Engel <joern@wohnheim.fh-wedel.de>
---
drivers/mtd/Kconfig | 4 ++++
drivers/mtd/chips/Kconfig | 1 +
drivers/mtd/devices/Kconfig | 1 +
kernel/Makefile | 3 ++-
4 files changed, 8 insertions(+), 1 deletion(-)
--- linux-2.6.11cow/drivers/mtd/Kconfig~inter_module 2005-03-04 11:40:19.000000000 +0100
+++ linux-2.6.11cow/drivers/mtd/Kconfig 2005-03-09 23:24:05.000000000 +0100
@@ -2,6 +2,10 @@
menu "Memory Technology Devices (MTD)"
+# This doens't actually belong here, but mtd is the last user, so...
+config INTER_MODULE_CRAP
+ boolean
+
config MTD
tristate "Memory Technology Device (MTD) support"
help
--- linux-2.6.11cow/drivers/mtd/chips/Kconfig~inter_module 2005-03-04 11:40:19.000000000 +0100
+++ linux-2.6.11cow/drivers/mtd/chips/Kconfig 2005-03-09 23:24:05.000000000 +0100
@@ -31,6 +31,7 @@ config MTD_JEDECPROBE
config MTD_GEN_PROBE
tristate
+ select INTER_MODULE_CRAP
config MTD_CFI_ADV_OPTIONS
bool "Flash chip driver advanced configuration options"
--- linux-2.6.11cow/drivers/mtd/devices/Kconfig~inter_module 2005-03-04 11:40:19.000000000 +0100
+++ linux-2.6.11cow/drivers/mtd/devices/Kconfig 2005-03-09 23:24:05.000000000 +0100
@@ -202,6 +202,7 @@ config MTD_DOC2001PLUS
config MTD_DOCPROBE
tristate
select MTD_DOCECC
+ select INTER_MODULE_CRAP
config MTD_DOCECC
tristate
--- linux-2.6.11cow/kernel/Makefile~inter_module 2004-12-28 17:31:37.000000000 +0100
+++ linux-2.6.11cow/kernel/Makefile 2005-03-09 23:24:05.000000000 +0100
@@ -6,9 +6,10 @@ obj-y = sched.o fork.o exec_domain.o
exit.o itimer.o time.o softirq.o resource.o \
sysctl.o capability.o ptrace.o timer.o user.o \
signal.o sys.o kmod.o workqueue.o pid.o \
- rcupdate.o intermodule.o extable.o params.o posix-timers.o \
+ rcupdate.o extable.o params.o posix-timers.o \
kthread.o wait.o kfifo.o sys_ni.o
+obj-$(CONFIG_INTER_MODULE_CRAP) += intermodule.o
obj-$(CONFIG_FUTEX) += futex.o
obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o
obj-$(CONFIG_SMP) += cpu.o spinlock.o
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] restrict inter_module_* to its last users
2005-04-08 17:08 [PATCH] restrict inter_module_* to its last users Jörn Engel
@ 2005-04-08 17:24 ` Arjan van de Ven
2005-04-08 17:48 ` Andrew Morton
1 sibling, 0 replies; 7+ messages in thread
From: Arjan van de Ven @ 2005-04-08 17:24 UTC (permalink / raw)
To: Jörn Engel; +Cc: Andrew Morton, linux-kernel, linux-mtd
On Fri, 2005-04-08 at 19:08 +0200, Jörn Engel wrote:
> Derived from a patch Arjan sent around.
>
Signed-off-by: Arjan van de Ven <arjan@infradead.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] restrict inter_module_* to its last users
2005-04-08 17:08 [PATCH] restrict inter_module_* to its last users Jörn Engel
2005-04-08 17:24 ` Arjan van de Ven
@ 2005-04-08 17:48 ` Andrew Morton
2005-04-08 17:53 ` Josh Boyer
` (3 more replies)
1 sibling, 4 replies; 7+ messages in thread
From: Andrew Morton @ 2005-04-08 17:48 UTC (permalink / raw)
To: Jörn Engel; +Cc: linux-kernel, linux-mtd
Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
>
> Next step for inter_module removal. This patch makes the code
> conditional on its last users and shrinks the kernel binary for the
> huge majority of people.
If we do this, nobody will get around to fixing up the remaining users.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] restrict inter_module_* to its last users
2005-04-08 17:48 ` Andrew Morton
@ 2005-04-08 17:53 ` Josh Boyer
2005-04-08 18:01 ` Arjan van de Ven
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Josh Boyer @ 2005-04-08 17:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jörn Engel, linux-mtd, linux-kernel
On Fri, 2005-04-08 at 10:48 -0700, Andrew Morton wrote:
> Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
> >
> > Next step for inter_module removal. This patch makes the code
> > conditional on its last users and shrinks the kernel binary for the
> > huge majority of people.
>
> If we do this, nobody will get around to fixing up the remaining users.
Well, here's a good starting point to actually fix things:
http://www.kernel.org/pub/linux/kernel/people/rusty/Module/remove-inter-module-mtd.patch.bz2
josh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] restrict inter_module_* to its last users
2005-04-08 17:48 ` Andrew Morton
2005-04-08 17:53 ` Josh Boyer
@ 2005-04-08 18:01 ` Arjan van de Ven
2005-04-08 18:17 ` Jörn Engel
2005-04-09 8:00 ` David Woodhouse
3 siblings, 0 replies; 7+ messages in thread
From: Arjan van de Ven @ 2005-04-08 18:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jörn Engel, linux-kernel, linux-mtd
On Fri, 2005-04-08 at 10:48 -0700, Andrew Morton wrote:
> Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
> >
> > Next step for inter_module removal. This patch makes the code
> > conditional on its last users and shrinks the kernel binary for the
> > huge majority of people.
>
> If we do this, nobody will get around to fixing up the remaining users.
there is really only one, and how is this making it LESS likely? the
stuff remains deprecated and spews warnings, just like it is now....
just that other mortals now also don't get the kernel bloat...
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] restrict inter_module_* to its last users
2005-04-08 17:48 ` Andrew Morton
2005-04-08 17:53 ` Josh Boyer
2005-04-08 18:01 ` Arjan van de Ven
@ 2005-04-08 18:17 ` Jörn Engel
2005-04-09 8:00 ` David Woodhouse
3 siblings, 0 replies; 7+ messages in thread
From: Jörn Engel @ 2005-04-08 18:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mtd
On Fri, 8 April 2005 10:48:26 -0700, Andrew Morton wrote:
> Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
> >
> > Next step for inter_module removal. This patch makes the code
> > conditional on its last users and shrinks the kernel binary for the
> > huge majority of people.
>
> If we do this, nobody will get around to fixing up the remaining users.
I would do that personally if someone explained inter_module_* to me.
Right now, I have absolutely no clue what the perceived problem was
and how inter_module_* supposedly solved that problem.
Jörn
--
The strong give up and move away, while the weak give up and stay.
-- unknown
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] restrict inter_module_* to its last users
2005-04-08 17:48 ` Andrew Morton
` (2 preceding siblings ...)
2005-04-08 18:17 ` Jörn Engel
@ 2005-04-09 8:00 ` David Woodhouse
3 siblings, 0 replies; 7+ messages in thread
From: David Woodhouse @ 2005-04-09 8:00 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jörn Engel, linux-mtd, linux-kernel
On Fri, 2005-04-08 at 10:48 -0700, Andrew Morton wrote:
>
> > Next step for inter_module removal. This patch makes the code
> > conditional on its last users and shrinks the kernel binary for the
> > huge majority of people.
>
> If we do this, nobody will get around to fixing up the remaining
> users.
Oh, I'll fix them, and I'll be happy to see the back of the
inter_module_crap -- it went in over my objections in the first place.
But I want to deal with all the module / submodule loading crap first.
It all wants attention, and fixing up one deprecation warning alone is
just patching over the cracks.
--
dwmw2
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-04-09 8:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-08 17:08 [PATCH] restrict inter_module_* to its last users Jörn Engel
2005-04-08 17:24 ` Arjan van de Ven
2005-04-08 17:48 ` Andrew Morton
2005-04-08 17:53 ` Josh Boyer
2005-04-08 18:01 ` Arjan van de Ven
2005-04-08 18:17 ` Jörn Engel
2005-04-09 8:00 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).