linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adrian Bunk <bunk@stusta.de>
Cc: netdev@oss.sgi.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6 patch] drivers/net/wan/: possible cleanups
Date: Fri, 15 Apr 2005 18:49:56 +0100	[thread overview]
Message-ID: <1113587392.11155.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20050414232028.GD20400@stusta.de>

On Gwe, 2005-04-15 at 00:20, Adrian Bunk wrote:
> On Sun, Mar 27, 2005 at 05:38:38PM +0100, Alan Cox wrote:
> > On Sul, 2005-03-27 at 15:34, Adrian Bunk wrote:
> > >   - syncppp.c: sppp_input
> > >   - syncppp.c: sppp_change_mtu
> > >   - z85230.c: z8530_dma_sync
> > >   - z85230.c: z8530_txdma_sync
> > 
> > Please leave the z85230 ones at least. They are an intentional part of
> > the external API for writing other 85230 card drivers.
> 
> If they are part of an API, why aren't the prototypes for them in any 
> header file?

They were once. I guess that got "tided" at some point, possibly long
ago even before submission.

z8530_dma_sync and txdma_sync set up the device in DMA mode, or in DMA
one direction only mode. 


  reply	other threads:[~2005-04-15 17:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-27 14:34 [2.6 patch] drivers/net/wan/: possible cleanups Adrian Bunk
2005-03-27 16:38 ` Alan Cox
2005-04-14 23:20   ` Adrian Bunk
2005-04-15 17:49     ` Alan Cox [this message]
2005-04-17 23:47       ` Adrian Bunk
2005-04-18 12:55         ` Alan Cox
2005-04-18 21:44           ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2005-09-02  1:23 Adrian Bunk
2005-05-31  0:58 Adrian Bunk
2005-03-11 18:16 Adrian Bunk
2005-03-22 23:52 ` Jeff Garzik
2005-02-19  8:50 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1113587392.11155.33.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).