From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: jonsmirl@gmail.com, linux-kernel@vger.kernel.org, greg@kroah.com,
helgehaf@aitel.hist.no, torvalds@osdl.org
Subject: Re: Ignore disabled ROM resources at setup
Date: Tue, 30 Aug 2005 16:43:46 +1000 [thread overview]
Message-ID: <1125384226.11949.70.camel@gaston> (raw)
In-Reply-To: <20050829.223238.18109086.davem@davemloft.net>
On Mon, 2005-08-29 at 22:32 -0700, David S. Miller wrote:
> From: Jon Smirl <jonsmirl@gmail.com>
> Date: Tue, 30 Aug 2005 00:35:11 -0400
>
> > As far as I can tell no one has built recent hardware this way. But I
> > believe there are some old SCSI controllers that do this. I provided a
> > ROM API for disabling sysfs access, if we identify one of these cards
> > we should just add a call to it's driver to disable ROM access instead
> > of bothering with the copy. Currently the copy is not being used
> > anywhere in the kernel.
>
> Qlogic ISP is one such card, but there are several others.
>
> I think enabling the ROM is a very bad idea, since we in fact
> know it disables the I/O and MEM space decoders on a non-empty
> set of PCI cards.
This is why pci_map_rom is under driver control. There is still a
potential issue with userland using the "rom" file in sysfs, which is
why we probably should cleanup the pci_map_rom_copy to have the kernel
read the ROM once & backstore it upon request from the driver so that
further userland accesses will not toggle the real ROM enable.
Ben.
prev parent reply other threads:[~2005-08-30 6:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200508261859.j7QIxT0I016917@hera.kernel.org>
2005-08-30 2:38 ` Ignore disabled ROM resources at setup Benjamin Herrenschmidt
2005-08-30 3:15 ` Linus Torvalds
2005-08-30 4:47 ` Jon Smirl
2005-08-30 3:19 ` Benjamin Herrenschmidt
2005-08-30 3:52 ` Linus Torvalds
2005-08-30 4:09 ` Linus Torvalds
2005-08-30 4:20 ` David S. Miller
2005-08-30 4:37 ` Benjamin Herrenschmidt
2005-08-30 4:40 ` Linus Torvalds
2005-08-30 4:49 ` Benjamin Herrenschmidt
2005-08-30 5:29 ` Linus Torvalds
2005-08-30 6:46 ` Benjamin Herrenschmidt
2005-08-31 4:16 ` Benjamin Herrenschmidt
2005-08-30 4:51 ` Jon Smirl
2005-08-30 4:54 ` Benjamin Herrenschmidt
2005-08-30 5:15 ` Linus Torvalds
2005-08-30 14:39 ` Alan Cox
2005-08-30 15:29 ` Petr Vandrovec
2005-08-30 4:33 ` Benjamin Herrenschmidt
2005-08-30 5:03 ` Linus Torvalds
2005-08-30 6:40 ` Benjamin Herrenschmidt
2005-08-30 4:35 ` Jon Smirl
2005-08-30 5:32 ` David S. Miller
2005-08-30 6:43 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125384226.11949.70.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=helgehaf@aitel.hist.no \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).