* [PATCH] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()
@ 2019-11-09 16:37 Markus Elfring
2019-11-11 20:53 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-11-09 16:37 UTC (permalink / raw)
To: linux-omap, linux-arm-kernel, Laurent Pinchart, Russell King,
Sebastian Reichel, Tomi Valkeinen, Tony Lindgren
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 9 Nov 2019 17:19:35 +0100
A coccicheck run provided information like the following.
arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 258, but without a corresponding
object release within this function.
Generated by: scripts/coccinelle/free/put_device.cocci
Thus add the missed function call to fix the exception handling for
this function implementation.
Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/arm/mach-omap2/display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index 439e143cad7b..46012ca812f4 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -265,6 +265,7 @@ static int __init omapdss_init_of(void)
r = of_platform_populate(node, NULL, NULL, &pdev->dev);
if (r) {
pr_err("Unable to populate DSS submodule devices\n");
+ put_device(&pdev->dev);
return r;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()
2019-11-09 16:37 [PATCH] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of() Markus Elfring
@ 2019-11-11 20:53 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2019-11-11 20:53 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-omap, linux-arm-kernel, Laurent Pinchart, Russell King,
Sebastian Reichel, Tomi Valkeinen, LKML, kernel-janitors
* Markus Elfring <Markus.Elfring@web.de> [191109 08:38]:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 9 Nov 2019 17:19:35 +0100
>
> A coccicheck run provided information like the following.
>
> arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 258, but without a corresponding
> object release within this function.
>
> Generated by: scripts/coccinelle/free/put_device.cocci
>
> Thus add the missed function call to fix the exception handling for
> this function implementation.
Thanks applying into omap-for-v5.5/soc.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-11 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 16:37 [PATCH] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of() Markus Elfring
2019-11-11 20:53 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).